Conversation
mattleibow
requested review from
PureWeen,
mandel-macaque and
rachelkang
and removed request for
PureWeen and
rachelkang
23 tasks
PureWeen
requested changes
May 15, 2023
PureWeen
requested changes
May 23, 2023
mattleibow
changed the title
PureWeen
requested changes
May 24, 2023
PureWeen
approved these changes
May 24, 2023
Member
PureWeen
left a comment
PureWeen
left a comment
There was a problem hiding this comment.
Looks good! Once @rachelkang is happy let's merge
rachelkang
approved these changes
May 24, 2023
Member
rachelkang
left a comment
rachelkang
left a comment
There was a problem hiding this comment.
LGTM! Android ShowKeyboardOnFocus is happy, device tests are happy
Member
Author
|
Seems the iOS tap gestures to resign the responder are not working now :( Maybe the rebase will fix it... |
rmarinho
approved these changes
May 30, 2023
rmarinho
pushed a commit
that referenced
this pull request
May 30, 2023
* Use AppendToMapping for Focus commands * undo this * and this * different * Fix focus methods * this
samhouts
added
area-controls-editor
ghost
added
the
legacy-area-controls
Eilon
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-8.0.0-preview.5.8529
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR makes use of some new APIs to ensure the focus command is working in AOT as well as to remove complexity.
Part of the fix for #11662 and part of PR #13836