Implement all permutations of InputTransparent and CascadeInputTransparent#14846
Merged
Conversation
16a1694 to
1895907
Compare
Member
|
Probably also related: #9153 |
This reverts commit 9609697.
23 tasks
mattleibow
commented
May 12, 2023
# Conflicts: # src/Controls/tests/Xaml.UnitTests/Issues/Bz54334.xaml.cs
76157e7 to
2ed88fe
Compare
# Conflicts: # src/Controls/src/Core/Layout/Layout.cs
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jsuarezruiz
reviewed
Jul 3, 2023
| // There are 2 Layout types: Controls and Compatibility | ||
| interface IInputTransparentContainerElement | ||
| { | ||
| bool InputTransparent { get; } |
Contributor
There was a problem hiding this comment.
Could you include inline comments here?
hartez
approved these changes
Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
There are several input transparency issues and most of the fixes we have done fix some and potentially create new issues because of the way things are set up. My proposed fix is going to be similar to the changes for
IsEnabledwhen theIsEnabledis controlled by 3 parts:IsEnabled,Parent.IsEnabledandICommand.CanExecute.The
InputTransparentresult value is controlled by a few parts:InputTransparentproperty on the elementInputTransparentproperty on the PARENT but only iff theCascadeInputTransparentpermitsI also assume that:
However, this is semi-ambiguous as what happens when there are multiple nested layouts with different values? The table below tries to capture all the things in a truth table.
So far my observations are:
Given the code:
Issues Fixed