Transition away from implicit package references#14770
Merged
mattleibow merged 25 commits intomainfrom Apr 27, 2023
Merged
Conversation
Eilon
added
the
area-setup
mandel-macaque
approved these changes
Apr 26, 2023
| "</Project>", | ||
| "<PropertyGroup><Version>1.0.0-preview.1</Version></PropertyGroup></Project>"); | ||
|
|
||
| string target = shouldPack ? "Pack" : ""; |
Contributor
There was a problem hiding this comment.
no your change, but string.Empty should have been used.
mattleibow
commented
Apr 27, 2023
| ('@(_MauiImplicitRequiredPackageReference->Count())' != '0') "> | ||
|
|
||
| <PropertyGroup> | ||
| <_MauiValidateRefsPrefix>Starting with .NET 8, setting </_MauiValidateRefsPrefix> |
Member
Author
There was a problem hiding this comment.
These messages... @rmarinho what is the way to localize?
Member
There was a problem hiding this comment.
Use resources? how do you pull into here I think I saw something about that
Member
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
I created an issue for the localization part: #14804
I found a few plain text strings that we need to localize across our targets.
samhouts
approved these changes
Apr 27, 2023
This was referenced Apr 27, 2023
Contributor
|
Looks fine to me but I'd like @MackinnonBuck or @Eilon to review this too just in case there are things beyond my knowledge that can cause trouble down the road (specifically around Blazor). |
MackinnonBuck
approved these changes
Apr 27, 2023
samhouts
added
the
fixed-in-8.0.0-preview.4.8333
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR checks and then adds a warning if it finds that the developer does not have a package reference to .NET MAUI in the project file. Implicit package references cause issues with the Package Manager UI as well as the CLI.
Not only do with fix some issues, developers can now have better control over the packages included and the transitive dependencies.
The project templates now have an additional package:
We are keeping the variable so that developers can choose to allow the IDE to update the version of .NET MAUI being used. This can be replaced with an explicit version, but then will no longer receive updates when the IDE is updated.
This PR replaces #14576
Future Work