Call the correct Disconnect method from DisconnectHandler#14757
Merged
mattleibow merged 1 commit intomainfrom Apr 25, 2023
Merged
Call the correct Disconnect method from DisconnectHandler#14757mattleibow merged 1 commit intomainfrom
mattleibow merged 1 commit intomainfrom
Conversation
PureWeen
added
the
backport/suggested
jsuarezruiz
approved these changes
Apr 25, 2023
Contributor
|
@hartez |
mikeparker104
added
the
partner/cat 😻
hartez
added
the
backport/approved
Contributor
|
/backport to net7.0 |
Contributor
|
Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/5138866208 |
Contributor
|
@PureWeen Thanks! Literally just hit this in an attempt to work around a webview memory leak |
samhouts
removed
the
partner/cat 😻
samhouts
added
the
fixed-in-8.0.0-preview.4.8333
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
DisconnectHandler is currently calling the wrong method. It needs to call
DisconnectThis PR doesn't have tests because the failure is caught by
DisconnectHandlerDoesntCrash