Closed
Conversation
Member
|
Can we use windows7? net7.0-windows7? That does not super the wasdk and we can also have that work there? |
Member
Author
|
I'm closing this PR From what I can tell this is actually fixed on main by @mattleibow 's PR to nugetize things. I tested the net7.0 branch with the following PR and the packs produced from that PR are able to create WPF/Forms projects that live in harmony with MAUI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
If a project with
UseMauihasUseFormsorUseWPFspecified, then don't include the WinAppSDK bits.I tested this locally and for
WPFyou have to include these in your project so that we don't process the WPFXAMLI feel like this is ok for now. I didn't want to add too much conditional behavior in our code.
Issues Fixed
Fixes #6450