Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Scroll with the keyboard to not block entries and editors #13499

Merged
merged 22 commits into from
Mar 17, 2023
Merged

[iOS] Scroll with the keyboard to not block entries and editors #13499

merged 22 commits into from
Mar 17, 2023

Commits on Feb 21, 2023

  1. start of the Scroll implementation

    TJ Lambert committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    d53bf8b View commit details
    Browse the repository at this point in the history

  2. Massive rehaul with functionality

    TJ Lambert committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    764a5b1 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. add license comment

    TJ Lambert committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    1a40a18 View commit details
    Browse the repository at this point in the history

  2. Auto-format source code

    GitHub Actions Autoformatter committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    3e9edf9 View commit details
    Browse the repository at this point in the history

  3. Fix edge case where cursor is not inside the editor when we Next into it

    TJ Lambert committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    b97feee View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'TJ/ScrollKeyboard_Final' into ScrollKey… 

    …board_Final
    TJ Lambert committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    7a14d07 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. address first part Manuel comments and flip the move

    TJ Lambert committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    8466344 View commit details
    Browse the repository at this point in the history

  2. obsolete the keyboardInsetTracker

    TJ Lambert committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    7e1c83d View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Address Shane and some Manuel suggestions and allow listview and coll… 

    …ectionview scrolling
    TJ Lambert committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    c1cc0ff View commit details
    Browse the repository at this point in the history

  2. Optimize memory usage by changing closures to delegates

    TJ Lambert committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    9e8558e View commit details
    Browse the repository at this point in the history

  3. obsolete the ShellScrollViewTracker

    TJ Lambert committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    0029721 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2023

  1. Add tests and change RootController to ContainerView

    TJ Lambert committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    3b37360 View commit details
    Browse the repository at this point in the history

  2. Auto-format source code

    GitHub Actions Autoformatter committed Mar 8, 2023
    Configuration menu
    Copy the full SHA
    ee5937b View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. fixed issue with spamming clicks really fast

    TJ Lambert committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    058f9ea View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'TJ/ScrollKeyboard_Final' into ScrollKey… 

    …board_Final
    TJ Lambert committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    c4dc334 View commit details
    Browse the repository at this point in the history

  3. Fix rare race condition between events by moving to debounced method

    TJ Lambert committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    e52ee20 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Fix animation speed and allow scrollviews to come into view on non-sc… 

    …roll pages
    TJ Lambert committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    ac0e366 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. Make Manuel and Shane suggestions p2

    TJ Lambert committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    6390a85 View commit details
    Browse the repository at this point in the history

  2. Auto-format source code

    GitHub Actions Autoformatter committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    0b49cf3 View commit details
    Browse the repository at this point in the history

  3. set IsCurrentlyScrolling off in Disconnect

    TJ Lambert committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    81151d5 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2023

  1. add dimensions check

    TJ Lambert committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    c71e638 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'TJ/ScrollKeyboard_Final' into ScrollKey… 

    …board_Final
    TJ Lambert committed Mar 17, 2023
    Configuration menu
    Copy the full SHA
    d708982 View commit details
    Browse the repository at this point in the history