Revert "Add shell pages via controller instead of handler (#13332)"#13465
Merged
jfversluis merged 1 commit intomainfrom Feb 21, 2023
Merged
Revert "Add shell pages via controller instead of handler (#13332)"#13465jfversluis merged 1 commit intomainfrom
jfversluis merged 1 commit intomainfrom
Conversation
This reverts commit 0c6a2aa.
jfversluis
approved these changes
Feb 21, 2023
Member
|
/backport to release/8.0.1xx-preview1 |
Contributor
|
Started backporting to release/8.0.1xx-preview1: https://github.com/dotnet/maui/actions/runs/4234011534 |
tj-devel709
pushed a commit
to tj-devel709/maui
that referenced
this pull request
Feb 21, 2023
…)" (dotnet#13465) This reverts commit 0c6a2aa.
tj-devel709
pushed a commit
to tj-devel709/maui
that referenced
this pull request
Feb 21, 2023
…)" (dotnet#13465) This reverts commit 0c6a2aa.
samhouts
added
area-controls-shell
samhouts
added
the
fixed-in-8.0.0-preview.2.7871
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Adding the
Viewthat's part ofContainerViewControllerinstead of thePlatformViewcauses the layout to be wrong.