Conversation
Ultimately we want this to be an implicit reference which is not included by default and opt-in, however visual studio's Live Visual tree currently depends on the assembly existing and being loaded so we cannot yet remove it. The default property assignment can be removed once VS is ready for this.
* Add shell pages via controller instead of handler * Auto-format source code * - cleanup * - add wait * - push test into modal to isolate better --------- Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com>
* Use and clear a local nuget cache * more
#13336) * Have Frame use MinimumHeight/Width for minimums instead of constraints Fixes #13074 * Auto-format source code * Adjust test for other screen sizes/densities * Update src/Controls/src/Core/Compatibility/Handlers/Android/FrameRenderer.cs Co-authored-by: Manuel de la Pena <mandel@microsoft.com> * Make legacy min Frame size a constant * Auto-format source code * Make Frame test less awkward * Auto-format source code --------- Co-authored-by: GitHub Actions Autoformatter <autoformat@example.com> Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
PureWeen
previously approved these changes
Feb 18, 2023
PureWeen
approved these changes
Feb 18, 2023
dalexsoto
approved these changes
Feb 18, 2023
samhouts
added
area-controls-shell
ghost
added
the
legacy-area-controls
Eilon
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-8.0.0-preview.1.7762
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings especially in, the fix for adding an implicit reference to the Combat package.