Skip to content

[net7.0] [core] WeakEventManager+Subscription needs IEquatable #13249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 1 commit into from
Feb 10, 2023
Merged

[net7.0] [core] WeakEventManager+Subscription needs IEquatable #13249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/Core/src/WeakEventManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ void RemoveEventHandler(string eventName, object? handlerTarget, MemberInfo meth
}
}

struct Subscription
readonly struct Subscription : IEquatable<Subscription>
{
/// <include file="../docs/Microsoft.Maui/WeakEventManager.xml" path="//Member[@MemberName='.ctor']/Docs/*" />
public Subscription(WeakReference? subscriber, MethodInfo handler)
Expand All @@ -148,6 +148,12 @@ public Subscription(WeakReference? subscriber, MethodInfo handler)

public readonly WeakReference? Subscriber;
public readonly MethodInfo Handler;

public bool Equals(Subscription other) => Subscriber == other.Subscriber && Handler == other.Handler;

public override bool Equals(object? obj) => obj is Subscription other && Equals(other);

public override int GetHashCode() => Subscriber?.GetHashCode() ?? 0 ^ Handler.GetHashCode();
}
}
}