[iOS] Simplify the code used to set the same font size for Editor/Entry.#13150
Merged
[iOS] Simplify the code used to set the same font size for Editor/Entry.#13150
Conversation
PR #13140 landed with a property implementation that is more complicatd than needed (also a little unsafe). Changes in this PR: 1. Use a nullable nfloat to ensure that we do not use a magic number as the default value of the variable. 2. Simplify the if nests. There is no needed to have that many nested code to achiecve the same. This implementation does the same with a much simpler approach.
mandel-macaque
commented
Feb 7, 2023
mattleibow
reviewed
Feb 7, 2023
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
rmarinho
approved these changes
Feb 7, 2023
dalexsoto
approved these changes
Feb 7, 2023
samhouts
added
area-controls-editor
ghost
added
the
legacy-area-controls
Eilon
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-8.0.0-preview.1.7762
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #13140 landed with a property implementation that is more complicatd than needed (also a little unsafe).
Changes in this PR:
Please follow the logic of the changes in the comment review I gave to the original PR: #13140 (review)