[iOS] Fix issue rendering Button Background gradient with shadow#13022
Closed
jsuarezruiz wants to merge 7 commits intomainfrom
Closed
[iOS] Fix issue rendering Button Background gradient with shadow#13022jsuarezruiz wants to merge 7 commits intomainfrom
jsuarezruiz wants to merge 7 commits intomainfrom
Conversation
jsuarezruiz
added
t/bug
ghost
added
the
legacy-area-controls
mandel-macaque
suggested changes
Feb 7, 2023
Contributor
mandel-macaque
left a comment
mandel-macaque
left a comment
There was a problem hiding this comment.
Small changes needed. Mainly related to nullability. Nice use of the stack!
| var stack = new Stack<CALayer>(); | ||
| stack.Push(root); | ||
|
|
||
| while (stack.Count > 0) |
Contributor
There was a problem hiding this comment.
I like the use of the stack to build the iterator.
Co-authored-by: Manuel de la Pena <mandel@microsoft.com>
mandel-macaque
approved these changes
Feb 9, 2023
rmarinho
requested changes
Feb 10, 2023
Member
rmarinho
left a comment
rmarinho
left a comment
There was a problem hiding this comment.
Seems tests are crashing on iOS
Contributor
Author
|
Close this approach for now based on #13253 and we will reopen it with an alternative fix. |
Eilon
removed
the
legacy-area-controls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix issue rendering iOS Button with gradient and shadow.
To test/validate the changes, launch the .NET MAUI Gallery and navigate to the Button section. If the Background (Gradient) + Shadow sample is rendering correctly, the test has passed.
Issues Fixed
Fixes #12959