[Housekeeping] Port latest fixes from Xamarin.Forms to .NET MAUI#11420
Merged
[Housekeeping] Port latest fixes from Xamarin.Forms to .NET MAUI#11420
Conversation
jfversluis
requested changes
Nov 17, 2022
Member
jfversluis
left a comment
jfversluis
left a comment
There was a problem hiding this comment.
Looks like there is build errors here!
rmarinho
requested changes
Nov 17, 2022
Member
rmarinho
left a comment
rmarinho
left a comment
There was a problem hiding this comment.
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15542.cs(18,28): error CS0246: The type or namespace name 'TestShell' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Core\Compatibility.ControlGallery.Core.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15565.cs(18,28): error CS0246: The type or namespace name 'TestShell' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Core\Compatibility.ControlGallery.Core.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15542.cs(18,28): error CS0246: The type or namespace name 'TestShell' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\Android.UITests\Compatibility.ControlGallery.Android.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15565.cs(18,28): error CS0246: The type or namespace name 'TestShell' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\Android.UITests\Compatibility.ControlGallery.Android.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15565.cs(15,28): error CS0103: The name 'UITestCategories' does not exist in the current context [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\Android.UITests\Compatibility.ControlGallery.Android.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15565.cs(16,28): error CS0103: The name 'UITestCategories' does not exist in the current context [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\Android.UITests\Compatibility.ControlGallery.Android.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15542.cs(15,28): error CS0103: The name 'UITestCategories' does not exist in the current context [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\Android.UITests\Compatibility.ControlGallery.Android.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15542.cs(16,28): error CS0103: The name 'UITestCategories' does not exist in the current context [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\Android.UITests\Compatibility.ControlGallery.Android.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15542.cs(18,28): error CS0246: The type or namespace name 'TestShell' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\iOS.UITests\Compatibility.ControlGallery.iOS.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15565.cs(18,28): error CS0246: The type or namespace name 'TestShell' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\iOS.UITests\Compatibility.ControlGallery.iOS.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15542.cs(15,28): error CS0103: The name 'UITestCategories' does not exist in the current context [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\iOS.UITests\Compatibility.ControlGallery.iOS.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15542.cs(16,28): error CS0103: The name 'UITestCategories' does not exist in the current context [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\iOS.UITests\Compatibility.ControlGallery.iOS.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15565.cs(15,28): error CS0103: The name 'UITestCategories' does not exist in the current context [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\iOS.UITests\Compatibility.ControlGallery.iOS.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15565.cs(16,28): error CS0103: The name 'UITestCategories' does not exist in the current context [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\iOS.UITests\Compatibility.ControlGallery.iOS.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15542.cs(18,28): error CS0246: The type or namespace name 'TestShell' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\WinUI.UITests\WinUI.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15565.cs(18,28): error CS0246: The type or namespace name 'TestShell' could not be found (are you missing a using directive or an assembly reference?) [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\WinUI.UITests\WinUI.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15542.cs(15,28): error CS0103: The name 'UITestCategories' does not exist in the current context [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\WinUI.UITests\WinUI.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15542.cs(16,28): error CS0103: The name 'UITestCategories' does not exist in the current context [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\WinUI.UITests\WinUI.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15565.cs(15,28): error CS0103: The name 'UITestCategories' does not exist in the current context [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\WinUI.UITests\WinUI.UITests.csproj]
D:\a\_work\1\s\src\Compatibility\ControlGallery\src\Issues.Shared\Issue15565.cs(16,28): error CS0103: The name 'UITestCategories' does not exist in the current context [D:\a\_work\1\s\src\Compatibility\ControlGallery\test\WinUI.UITests\WinUI.UITests.csproj]
271 Warning(s)
20 Error(s)
Member
|
Still failing |
rmarinho
approved these changes
Nov 28, 2022
PureWeen
requested changes
Nov 29, 2022
PureWeen
requested changes
Mar 1, 2023
| SearchHandler = Shell.GetSearchHandler(Page); | ||
| } | ||
| else if (e.PropertyName == Shell.TitleViewProperty.PropertyName) | ||
| else if (e.PropertyName == Shell.TitleViewProperty.PropertyName || e.PropertyName == VisualElement.HeightProperty.PropertyName || e.PropertyName == VisualElement.WidthProperty.PropertyName) |
Member
There was a problem hiding this comment.
Can we change this to use e.IsOneOf ?
Contributor
|
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
src/Controls/src/Core/Compatibility/Handlers/Shell/iOS/ShellPageRendererTracker.cs
Outdated
Show resolved
Hide resolved
PureWeen
approved these changes
Mar 7, 2023
jfversluis
approved these changes
Mar 9, 2023
samhouts
added
the
fixed-in-8.0.0-preview.3.8149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Port latest fixes from Xamarin.Forms to .NET MAUI.
Issues Fixed
Fixes #10128