Skip to content

fix issue 9255 (Wrong Date format DatePicker Windows)#11073

Closed
Miro382 wants to merge 1 commit intodotnet:mainfrom
Miro382:fix-9255
Closed

fix issue 9255 (Wrong Date format DatePicker Windows)#11073
Miro382 wants to merge 1 commit intodotnet:mainfrom
Miro382:fix-9255

Conversation

@Miro382
Copy link

@Miro382 Miro382 commented Nov 2, 2022

Description of Change

Fix bad date format for Windows platform.
Bug description:
If the date format is set to yyyy-MM-dd.
In Android the date shows as 2022-08-09.
In Windows the date shows as 2022-8-9.

Issues Fixed

Fixes 9255

@ghost ghost added the community ✨ Community Contribution label Nov 2, 2022
@ghost
Copy link

ghost commented Nov 2, 2022

Hey there @Miro382! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@Miro382 Miro382 changed the title fix issue 9255 fix issue 9255 (Wrong Date format DatePicker Windows) Nov 2, 2022
@Eilon Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Nov 3, 2022
@rmarinho
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jfversluis jfversluis self-assigned this Jan 30, 2023
@jfversluis
Copy link
Member

Hey @Miro382! Thank you so much for your contribution here! While looking into this one, I found that there was already #9924.

Now which one was I going to pick?! 🤷‍♂️

First, the other PR was earlier, so that was one. Then second, what their PR has over this one is that it's a bit more flexible, but I guess what really pushed me over the line was that it also added tests.

Don't get me wrong, I very much appreciate the time and effort you put into this and I really wish I could take in both your PRs and make you .NET MAUI contributors, but in this case I'm going to go with the other PR.

Just wanted to give you my thoughts here, maybe it can be helpful in hopefully future contributions that we will see from you. I promise that we will look at them faster from here on out 😬

Thank you again!

@jfversluis jfversluis closed this Feb 3, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
@Eilon Eilon added area-controls-datetimepicker DatePicker, TimePicker and removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-controls-datetimepicker DatePicker, TimePicker community ✨ Community Contribution platform/windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Date format DatePicker wrong in Windows

5 participants