Add FrameRenderer to all our existing tests and then resolve found issues#10751
Closed
Add FrameRenderer to all our existing tests and then resolve found issues#10751
FrameRenderer to all our existing tests and then resolve found issues#10751Conversation
PureWeen
commented
Oct 18, 2022
PureWeen
changed the title
PureWeen
force-pushed
the
move_init_to_mapper
branch
from
73cbb35 to
e17604e
Compare
PureWeen
force-pushed
the
move_init_to_mapper
branch
from
5b91a06 to
a5129c1
Compare
PureWeen
changed the title
FrameRenderer to all our existing tests and then resolve found issues
PureWeen
force-pushed
the
move_init_to_mapper
branch
from
a5129c1 to
9384533
Compare
rmarinho
added a commit
that referenced
this pull request
Jan 2, 2023
) Fixes #10220 Fixes #10503 Fixes #8840 ### Description of Change The `AndroidBatchMapper` is manually called on `ViewHandler` meaning if you have a `Handler` that just uses the `ViewHandler.Mapper` and doesn't use our base class then everything inside `AndroidBatchMapper` won't run. I have a different PR that fixes this across the [board](#10751). This PR isolates the changes to `Frame` specifically to minimize the effect of this PR. This PR also takes the `Container` code we have in `ViewHandler` and applies to `Frame` so that `Frame` can benefit from all the `Container` scenarios as well. ### Issues Fixed Fixes #10220 Fixes #10503 Fixes #10503 Fixes #8840
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
HandlerTestBasecode intoTestUtils.DeviceTests.Runnersso that it can be reused by all of our runners. Blazor/Controls/Core has been accumulating a lot of the same code and I really want to use the generic handler tests we have inside Core to testFrameRendererand other renderers inside controlsIssues Fixed
Fixes #10220
Fixes #10503
Fixes #10503
Fixes #8840