Avoid using string.Format with null args

dotnet · Oct 18, 2024 · 5ce0498 · 5ce0498
1 parent 79db39b
commit 5ce0498
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/Controls/src/Build.Tasks/BuildException.cs b/src/Controls/src/Build.Tasks/BuildException.cs
@@ -30,7 +30,12 @@ protected BuildException(System.Runtime.Serialization.SerializationInfo info, Sy
 
 		static string FormatMessage(BuildExceptionCode code, IXmlLineInfo xmlinfo, object[] args)
 		{
-			var message = string.Format(ErrorMessages.ResourceManager.GetString(code.ErrorMessageKey), args);
+			var message = ErrorMessages.ResourceManager.GetString(code.ErrorMessageKey);
+			if (args is not null)
+			{
+				message = string.Format(message, args);
+			}
+
 			var ecode = code.Code;
 			var position = xmlinfo == null || !xmlinfo.HasLineInfo() ? "" : $"({xmlinfo.LineNumber},{xmlinfo.LinePosition})";