Skip to content

[Android] Fix Button text not fully visible at maximum font size #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsuarezruiz merged 3 commits into from
Aug 27, 2025
Merged

[Android] Fix Button text not fully visible at maximum font size #661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b160d6
Fixed-30829
Vignesh-SF3580 Aug 20, 2025
8282149
Merge branch 'main' into fix-30829
jsuarezruiz Aug 26, 2025
fc1c99f
Merge branch 'main' into fix-30829
jsuarezruiz Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 10.0/Apps/DeveloperBalance/Pages/ManageMetaPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
<Grid ColumnSpacing="{StaticResource LayoutSpacing}" ColumnDefinitions="*,Auto" Margin="0,10">
<Button Text="Save" Command="{Binding SaveCategoriesCommand}"
SemanticProperties.Description="Save Categories"
HeightRequest="{OnIdiom 44,Desktop=60}" Grid.Column="0" />
MinimumHeightRequest="{OnIdiom 44,Desktop=60}" Grid.Column="0" />

<Button ImageSource="{StaticResource IconAdd}"
Command="{Binding AddCategoryCommand}" Grid.Column="1"
Expand Down Expand Up @@ -128,7 +128,7 @@
<Grid ColumnSpacing="{StaticResource LayoutSpacing}" ColumnDefinitions="*,Auto" Margin="0,10">
<Button Text="Save" Command="{Binding SaveTagsCommand}"
SemanticProperties.Description="Save Tags"
HeightRequest="{OnIdiom 44,Desktop=60}" Grid.Column="0" />
MinimumHeightRequest="{OnIdiom 44,Desktop=60}" Grid.Column="0" />

<Button ImageSource="{StaticResource IconAdd}"
Command="{Binding AddTagCommand}" Grid.Column="1"
Expand Down
2 changes: 1 addition & 1 deletion 10.0/Apps/DeveloperBalance/Pages/ProjectDetailPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@
</ScrollView>

<Button Text="Save"
HeightRequest="{OnIdiom 44, Desktop=60}"
MinimumHeightRequest="{OnIdiom 44, Desktop=60}"
Command="{Binding SaveCommand}" />

<Grid HeightRequest="44">
Expand Down
2 changes: 1 addition & 1 deletion 10.0/Apps/DeveloperBalance/Pages/TaskDetailPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
</sf:SfTextInputLayout>

<Button
HeightRequest="{OnIdiom 44, Desktop=60}"
MinimumHeightRequest="{OnIdiom 44, Desktop=60}"
Text="Save"
Command="{Binding SaveCommand}"/>
</VerticalStackLayout>
Expand Down
4 changes: 2 additions & 2 deletions 9.0/Apps/DeveloperBalance/Pages/ManageMetaPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
<Grid ColumnSpacing="{StaticResource LayoutSpacing}" ColumnDefinitions="*,Auto" Margin="0,10">
<Button Text="Save" Command="{Binding SaveCategoriesCommand}"
SemanticProperties.Description="Save Categories"
HeightRequest="{OnIdiom 44,Desktop=60}" Grid.Column="0" />
MinimumHeightRequest="{OnIdiom 44,Desktop=60}" Grid.Column="0" />

<Button ImageSource="{StaticResource IconAdd}"
Command="{Binding AddCategoryCommand}" Grid.Column="1"
Expand Down Expand Up @@ -128,7 +128,7 @@
<Grid ColumnSpacing="{StaticResource LayoutSpacing}" ColumnDefinitions="*,Auto" Margin="0,10">
<Button Text="Save" Command="{Binding SaveTagsCommand}"
SemanticProperties.Description="Save Tags"
HeightRequest="{OnIdiom 44,Desktop=60}" Grid.Column="0" />
MinimumHeightRequest="{OnIdiom 44,Desktop=60}" Grid.Column="0" />

<Button ImageSource="{StaticResource IconAdd}"
Command="{Binding AddTagCommand}" Grid.Column="1"
Expand Down
2 changes: 1 addition & 1 deletion 9.0/Apps/DeveloperBalance/Pages/TaskDetailPage.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
</sf:SfTextInputLayout>

<Button
HeightRequest="{OnIdiom 44, Desktop=60}"
MinimumHeightRequest="{OnIdiom 44, Desktop=60}"
Text="Save"
Command="{Binding SaveCommand}"/>
</VerticalStackLayout>
Expand Down
Loading