Skip to content

fix: DevFlow broker daemon spawn args #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Redth merged 2 commits into from
Apr 28, 2026
Merged

fix: DevFlow broker daemon spawn args #175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a92877
fix: DevFlow broker daemon spawn args
davidortinau Apr 28, 2026
d585b64
docs: update broker spawn comment to match new argv
davidortinau Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/Cli/Microsoft.Maui.Cli/DevFlow/Broker/BrokerClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,9 @@ private static void CleanupStaleBroker()
string arguments;

// If running via `dotnet run` or `dotnet <dll>`, exePath is the dotnet host.
// In that case, use `dotnet <entryDll> broker start --foreground` instead.
// In that case, use `dotnet <entryDll> devflow broker start --foreground` instead.
// Note: the `devflow` token is required because broker is a subcommand of devflow,
// not a top-level CLI command.
if (exePath.EndsWith("dotnet", StringComparison.OrdinalIgnoreCase)
|| exePath.EndsWith("dotnet.exe", StringComparison.OrdinalIgnoreCase))
{
Expand All @@ -243,12 +245,12 @@ private static void CleanupStaleBroker()
return null;
}
fileName = exePath;
arguments = $"\"{dllPath}\" broker start --foreground";
arguments = $"\"{dllPath}\" devflow broker start --foreground";

Copilot AI Apr 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment immediately above this branch still says the daemon is started with dotnet <entryDll> broker start --foreground, but the actual spawn args now include devflow broker .... Please update that comment to match the new argv so future changes don’t reintroduce this bug.

Copilot uses AI. Check for mistakes.

@Redth Redth Apr 28, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot apply changes based on this feedback

}
else
{
fileName = exePath;
arguments = "broker start --foreground";
arguments = "devflow broker start --foreground";
}

var startInfo = new ProcessStartInfo
Expand Down
Loading