Skip to content

Remove CFSClean gain#17

Merged
rmarinho merged 1 commit into
mainfrom
fix-cfs-clean
Mar 23, 2026
Merged

Remove CFSClean gain#17
rmarinho merged 1 commit into
mainfrom
fix-cfs-clean

Conversation

@rmarinho
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings March 23, 2026 18:24
@rmarinho rmarinho changed the title Remove cfs clean again Remove CFSClean gain Mar 23, 2026
@rmarinho rmarinho merged commit b652649 into main Mar 23, 2026
5 checks passed
@rmarinho rmarinho deleted the fix-cfs-clean branch March 23, 2026 18:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Azure DevOps official pipeline configuration for DevFlow by simplifying the 1ES networkIsolationPolicy setting, likely to stop applying CFS clean policies during official builds.

Changes:

  • Removed CFSClean and CFSClean2 from networkIsolationPolicy, leaving only Permissive.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Redth added a commit that referenced this pull request Apr 16, 2026
Replace the remaining Cairo and Pango DllImport usage in GTK4 CairoCanvas with the managed GirCore APIs.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Redth added a commit that referenced this pull request Apr 16, 2026
Port Maui.Gtk PR #17: replace DllImports in CairoCanvas
@jfversluis jfversluis added this to the v0.1.0-preview.5 milestone May 6, 2026
mattleibow added a commit that referenced this pull request May 12, 2026
Critical/High fixes:
- #1: Use namespace+class for unique hint names (prevents AddSource crash
  when two pages share the same simple class name)
- #2: CrossFileResolver uses FQN lookup + ambiguity detection for
  duplicate simple names across namespaces
- #3: CollectionView conditional rendering fixed — no more [[double brackets]],
  uses unified annotation list builder
- #4: Root ContentPage walks children directly, preventing SemanticProperties
  on root from swallowing the entire page
- #5: Visibility conditions on layout containers now propagate as
  condition group wrappers ('When [visible when X = true]:')
- #6: Property-element content (ContentPage.Content, ScrollView.Content)
  no longer dropped — unknown property elements are transparent by default,
  only known non-visual ones (Resources, Triggers, etc.) are suppressed
- #7: Shell routes stored in UiElement for Shell page markdown

Medium fixes:
- #8: Promoted containers (Border with Description) now walk children too,
  preserving actionable descendants like buttons
- #9: Unresolved user controls kept as placeholders (previously dropped),
  important for third-party controls with SemanticProperties
- #10: DataTrigger with IsVisible=False setter now correctly inverted
  to 'hidden when Property = Value' instead of 'visible when'
- #11: IsVisible=False elements skipped entirely — not reachable by screen
  readers, should not appear in accessibility-first index
- #12: Aggregate namespace validated as legal C# before emitting
- #13: Always use global:: for page references in aggregate, even for
  no-namespace pages
- #14: BindingRegex now requires whitespace after 'Binding' keyword,
  preventing false matches like {BindingSource}
- #15: CrossFileResolver uses in-progress set for cycle detection,
  preventing partial cache on indirect A→B→A cycles

Low fixes:
- #16: Dead emptyViewChildren code block removed
- #17: Removed unused TemplateVariants from dead CollectionView code

104 exact-match tests, all passing.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants