Skip to content

ci: add stub workflow for review.agent discovery#120

Merged
PureWeen merged 2 commits into
mainfrom
feat/review-workflow-stub
Apr 21, 2026
Merged

ci: add stub workflow for review.agent discovery#120
PureWeen merged 2 commits into
mainfrom
feat/review-workflow-stub

Conversation

@PureWeen
Copy link
Copy Markdown
Member

Summary

Adds a minimal stub review.agent.lock.yml to main so that GitHub Actions can discover the workflow_dispatch trigger. This enables testing the real review workflow from the feature branch (feat/expert-review-workflow, PR #118) using:

gh workflow run review.agent.lock.yml --ref feat/expert-review-workflow -f pr_number=115

Why this is needed

GitHub requires workflow_dispatch workflows to exist on the default branch before they can be triggered via API/CLI/UI. The real workflow only exists on feat/expert-review-workflow (PR #118).

What it does

Safe to merge

  • permissions: {} — no permissions granted
  • The stub job just prints a message and exits 1
  • No secrets, no checkout, no tools

GitHub Actions requires workflow_dispatch workflows to exist on the
default branch before they can be triggered via API/CLI. This stub
enables discovery so that the real workflow on feat/expert-review-workflow
can be dispatched with --ref.

The stub exits with failure if run directly — it only serves as a
discovery placeholder. Once PR #118 merges, it will be replaced by
the real compiled workflow.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 21, 2026 20:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a minimal placeholder GitHub Actions workflow on main so workflow_dispatch can be discovered, enabling gh workflow run ... --ref <branch> to execute the real workflow defined on a feature branch (per PR #118).

Changes:

  • Introduces a stub review.agent.lock.yml with a workflow_dispatch trigger and pr_number input.
  • Adds a single stub job that prints guidance and exits non-zero to prevent accidental direct use.

pr_number:
description: 'PR number to review'
required: true
type: number
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow_dispatch inputs don't support type: number (supported types are typically string (default), boolean, choice, environment). Using an unsupported type can make the workflow invalid and prevent GitHub from discovering/dispatching it. Suggest removing type: entirely (defaults to string) or switching to type: string and letting the caller pass numeric text.

Suggested change
type: number
type: string

Copilot uses AI. Check for mistakes.
Shows as "skipped" in Actions UI instead of a red failure if
accidentally triggered without --ref.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@PureWeen
Copy link
Copy Markdown
Member Author

Re: Copilot suggestion to change type: number to type: string

Not a valid concern — type: number is a supported workflow_dispatch input type (alongside string, boolean, choice, and environment). It was added to GitHub Actions after the original four types.

The real workflow on feat/expert-review-workflow and the gh-aw compiled lock file both use type: number for this input, and the compiler accepted it without warnings. The stub should match the real workflow's schema to ensure consistent behavior when dispatching with --ref.

@PureWeen PureWeen merged commit e55ff22 into main Apr 21, 2026
1 check passed
@PureWeen PureWeen deleted the feat/review-workflow-stub branch April 21, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants