Skip to content

Conversation

@carlossanlop
Copy link
Contributor

This was missed due to being in a separate file.

These will now be in the same file as the other versioning ones, and will also affect the tests and resource versions but that would not be a problem.

@carlossanlop carlossanlop self-assigned this Apr 2, 2025
@carlossanlop carlossanlop requested a review from a team as a code owner April 2, 2025 20:45
@carlossanlop carlossanlop changed the title Fix S.R.CS.Unsafe AssemblYVersion and move properties to Versioning.props Fix S.R.CS.Unsafe AssemblyVersion and move properties to Versioning.props Apr 2, 2025
@ericstj ericstj requested review from a team and stephentoub as code owners April 3, 2025 15:08
@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 3, 2025

Pushed one commit to avoid the Versioning.csproj project creating a package.

Disregard. I just noticed that the IsPackable property was already in Versioning.props. I reverted my commit.

Copy link
Member

@ericstj ericstj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this to ship upstack packages. I reviewed changes here and past versioning changes. I did not notice any other problems.

I also built a test application. It's a .NETFramework application that multi-targets to every supported version of .NETFramework.

I then run dotnet add package Id --prerelease for every package we build in maintenance packages with a feed to my locally built packages. This picks the latest from nuget / local build.

I then build this and look at the generated bindingRedirects to ensure none are required on any framework.

Here's my test if you'd like to try it.
testMP.zip

We might want to integrate something like this into the build.

Note that it must use packages, because the versioning problem only exists when combining things we already published with those built locally. If we just look at build output it will never require redirects.

@carlossanlop
Copy link
Contributor Author

Thanks both. Merging and queuing a new official build.

@carlossanlop carlossanlop merged commit fceae2a into dotnet:main Apr 3, 2025
5 checks passed
@carlossanlop carlossanlop deleted the FixUnsafeVersioning branch April 3, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants