Remove AssemblyVersion pinned constraint for .NET Standard #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the errors. |
carlossanlop
changed the title
ericstj
reviewed
Nov 8, 2024
carlossanlop
requested review from
stephentoub,
a team,
cheenamalhotra and
David-Engel
as code owners
carlossanlop
force-pushed
the
BumpAssemblyVersionNetStandard
branch
from
13230a8 to
2cf036a
Compare
carlossanlop
removed request for
a team,
stephentoub,
cheenamalhotra and
David-Engel
ericstj
reviewed
Nov 11, 2024
There was a problem hiding this comment.
You had already mentioned offline that you intended to reduce this PR to just System.Memory and System.Threading.Tasks.Extensions. I confirmed that through inspecting assemblies in packages and ref packs. I added a couple more comments around things that we might want to consider for System.Buffers and System.Numerics.Vectors. Looks like those two were different because of the reference assemblies that they used to ship.
src/System.Reflection.DispatchProxy/src/System.Reflection.DispatchProxy.csproj
Outdated
Show resolved
Hide resolved
src/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.ilproj
Outdated
Show resolved
Hide resolved
src/System.Threading.Tasks.Extensions/src/System.Threading.Tasks.Extensions.csproj
Outdated
Show resolved
Hide resolved
|
In general, if a previously frozen AssemblyVersion property isn't frozen anymore, please move it into the PropertyGroup that contains all the moving versions. And put the properties with the same name together. |
ViktorHofer
reviewed
Nov 11, 2024
ViktorHofer
reviewed
Nov 11, 2024
src/System.Threading.Tasks.Extensions/src/System.Threading.Tasks.Extensions.csproj
Outdated
Show resolved
Hide resolved
ViktorHofer
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159
We need to make sure that the AssemblyVersion for the netstandard2.0 DLLs of the new packages is greater than the AssemblyVersion for the netstandard2.0 DLLs of the last released packages in nuget.org, similar to what we've been doing for .NET Framework AssemblyVersions.
For some of these cases we need to be mindful of keeping the new netstandard2.0 AssemblyVersion under the AssemblyVersion of the last released netcoreappX.X version.
I collected all the numbers before and after:
System.Buffers
C:\Program Files\dotnet (netcoreapp2.1):
nuget.org (netstandard2.0):
main (netstandard2.0):
This PR (netstandard2.0):
System.Memory
C:\Program Files\dotnet (netcoreapp2.1):
nuget.org (netstandard2.0):
main (netstandard2.0):
This PR (netstandard2.0):
System.Numerics.Vectors
C:\Program Files\dotnet (netcoreapp2.1):
nuget.org (netstandard2.0):
main (netstandard2.0):
This PR (netstandard2.0):
System.Runtime.CompilerServices.Unsafe
C:\Program Files\dotnet (net6.0):
nuget.org (netstandard2.0):
main (netstandard2.0):
This PR (netstandard2.0):
System.Threading.Tasks.Extensions
C:\Program Files\dotnet (netcoreapp2.1):
nuget.org (netstandard2.0):
main (netstandard2.0):
This PR (netstandard2.0):
System.Reflection.DispatchProxy
C:\Program Files\dotnet (netcoreapp3.1):
nuget.org (netstandard2.0):
main (netstandard2.0):
This PR (netstandard2.0):
System.Data.SqlClient
This assembly does not need the change.