Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DotNetFinalVersionKind to remove the patch version and prerelease qualifiers from package names #153

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

carlossanlop
Copy link
Member

I missed this property in my previous PR. Without it, the packages are still getting pushed to the dotnet-libraries feed with the prerelease qualifiers and the patch version in their names. Example: https://dnceng.visualstudio.com/public/_artifacts/feed/dotnet-libraries/NuGet/System.Numerics.Vectors/overview/4.6.0-rtm.24531.3

After merging this, each release will be pushed to its own isolated feed, and the package names will not contain any prerelease qualifiers and patch versions in their names.

We don't have to merge this right away. Let's wait until we finish fine tuning the last details in the repo.

eng/Versions.props Outdated Show resolved Hide resolved
@carlossanlop carlossanlop marked this pull request as draft October 31, 2024 18:38
@carlossanlop
Copy link
Member Author

Changing it to draft so we don't merge it accidentally. I'd like to wait until everything else looks good.

@carlossanlop carlossanlop mentioned this pull request Nov 1, 2024
4 tasks
@ericstj
Copy link
Member

ericstj commented Nov 1, 2024

So what's the story for how this works - will we check it in and leave it on - or toggle it in source on/off/on/off? Did you consider passing it in when scheduling the build? Where did you want to document your process for releasing m-p?

@carlossanlop
Copy link
Member Author

So what's the story for how this works - will we check it in and leave it on - or toggle it in source on/off/on/off?

Just like we do in release/8.0 in runtime: we need to turn off is the <IsPackable> property in all packages until we need to publish a new fix.

Did you consider passing it in when scheduling the build? Where did you want to document your process for releasing m-p?

I'd rather do what we do in runtime: keep the DotNetFinalVersionKind property enabled permanently.

This is already partially documented in the README.md, but I can expand it. I'll add the extra info in this PR.

@ericstj
Copy link
Member

ericstj commented Nov 1, 2024

Ok, keeping this on all the time means it will be difficult to do any sort of preview. That might be OK considering that we only intend to bring stuff over that's already in servicing mode.

@carlossanlop
Copy link
Member Author

Ok, keeping this on all the time means it will be difficult to do any sort of preview.

Would there be an issue if we just delete the property to revert back to preview mode? That should revert back to publishing to the dotnet-libraries feed and would add the prerelease suffixes to the nupkgs. Then when we're ready, we add the property back.

@carlossanlop carlossanlop marked this pull request as ready for review November 5, 2024 00:15
@carlossanlop carlossanlop merged commit a8adb65 into dotnet:main Nov 5, 2024
5 checks passed
@carlossanlop carlossanlop deleted the DotNetFinalVersionKind branch November 5, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants