[generator] Remove unreachable code #8237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An earlier `wrap != null` condition ends with a `return` so any check or code assuming `wrap == null` must always be executed, while any `wrap != null` will never be.
mandel-macaque
approved these changes
Mar 30, 2020
|
Easier to review when hiding whitespaces |
rolfbjarne
approved these changes
Mar 30, 2020
chamons
approved these changes
Mar 30, 2020
dalexsoto
approved these changes
Mar 30, 2020
|
Build success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier
wrap != nullcondition ends with areturnso any check orcode assuming
wrap == nullmust always be executed, while anywrap != nullwill never be.