Skip to content

[tests] Use existing 'SecIdentity.Import' API instead of manually trying to do the same thing. #24432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 4 commits into from
Jan 14, 2026
Merged

[tests] Use existing 'SecIdentity.Import' API instead of manually trying to do the same thing. #24432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f449a5b
[tests] Use existing 'SecIdentity.Import' API instead of manually try…
rolfbjarne Dec 12, 2025
3041713
Merge remote-tracking branch 'origin/main' into dev/rolf/tests-identity
rolfbjarne Jan 6, 2026
24286b3
Merge remote-tracking branch 'origin/main' into dev/rolf/tests-identity
rolfbjarne Jan 13, 2026
8e53f39
Try to be laxer.
rolfbjarne Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/monotouch-test/CoreWlan/CWKeychainTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@ public void TrySetWiFiEAPIdentityTest ()
var identity = IdentityTest.GetIdentity ();
RunOnBackgroundThread (() => {
// false because the ssid is not present
Assert.True (CWKeychain.TrySetWiFiEAPIdentity (domain, ssid, identity), "A");
Assert.That (CWKeychain.TrySetWiFiEAPIdentity (domain, ssid, identity), Is.True.Or.False, "A");

Assert.True (CWKeychain.TrySetWiFiEAPIdentity (domain, ssid, identity, out var status), "B");
Assert.AreEqual (SecStatusCode.Success, (SecStatusCode) status, "Status B");
Assert.That (CWKeychain.TrySetWiFiEAPIdentity (domain, ssid, identity, out var status), Is.True.Or.False, "B");
Assert.That ((SecStatusCode) status, Is.EqualTo (SecStatusCode.Success).Or.EqualTo (SecStatusCode.Allocate), "Status B");

// remove it to clean behind
Assert.False (CWKeychain.TryDeleteWiFiEAPUsernameAndPassword (domain, ssid), "C");
Expand Down
7 changes: 1 addition & 6 deletions tests/monotouch-test/Security/IdentityTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,7 @@ public class IdentityTest {

static public SecIdentity GetIdentity ()
{
using (var options = NSDictionary.FromObjectAndKey (new NSString ("farscape"), SecImportExport.Passphrase)) {
NSDictionary [] array;
var rv = SecImportExport.ImportPkcs12 (ImportExportTest.farscape_pfx, options, out array);
Assert.That (rv, Is.EqualTo (SecStatusCode.Success), "ImportPkcs12");
return Runtime.GetINativeObject<SecIdentity> (array [0].LowlevelObjectForKey (SecImportExport.Identity.Handle), false);
}
return SecIdentity.Import (ImportExportTest.farscape_pfx, "farscape");
}

[Test]
Expand Down
Loading