[xma] Added targets and tasks to copy modified dll and pdb files back to Windows #22677

mauroa · 2025-04-25T01:51:59Z

With the new ICorDebug engine for MAUI, we need the debugger to always load the assemblies from Windows. Given that some dll and pdb files changes as part of the remote build, we need a mechanism to copy those modified files back to the Windows OutputPath, so the debugger can always load the right files. Otherwise, the debugger will try to load files that are not the same that are in the running app, so no symbols will be loaded. This also improves the debugger performance by ensuring the files are not loaded remotely but locally

Copilot

Pull Request Overview

This PR adds targets and tasks to ensure that modified dll and pdb files from remote builds are copied back to the Windows output directory so the debugger loads the correct assemblies and symbols.

Updated the Windows unit tests to verify that updated output files (assemblies report and changed output files zip) are generated and correctly extracted.
Modified the Zip task to avoid copying inputs or creating empty output files on Windows.
Introduced two new tasks, CalculateAssembliesReport and AnalyzeFileChanges, to generate an assemblies report and determine which files have changed.

Reviewed Changes

Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.

File	Description
tests/dotnet/UnitTests/WindowsTest.cs	Updated test logic to assert the existence of new output files and to validate file changes.
msbuild/Xamarin.MacDev.Tasks/Tasks/Zip.cs	Modified the Zip task to prevent copying inputs and creating empty output files on Windows.
msbuild/Xamarin.MacDev.Tasks/Tasks/CalculateAssembliesReport.cs	Added a new task to generate an assemblies report file based on file metadata.
msbuild/Xamarin.MacDev.Tasks/Tasks/AnalyzeFileChanges.cs	Added a new task to analyze file changes by comparing file length and MVID information.

Files not reviewed (2)

msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.Common.After.targets: Language not supported
msbuild/Xamarin.iOS.Tasks.Windows/Xamarin.iOS.Windows.After.targets: Language not supported

github-actions · 2025-04-25T01:56:07Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

github-actions · 2025-04-28T14:45:50Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

… to Windows With the new ICorDebug engine for MAUI, we need the debugger to always load the assemblies from Windows. Given that some dll and pdb files changes as part of the remote build, we need a mechanism to copy those modified files back to the Windows OutputPath, so the debugger can always load the right files. Otherwise, the debugger will try to load files that are not the same that are in the running app, so no symbols will be loaded. This also improves the debugger performance by ensuring the files are not loaded remotely but locally

… files update logic

github-actions · 2025-04-28T14:54:29Z

⚠️ Your code has been reformatted. ⚠️

If this is not desired, add the actions-disable-autoformat label, and revert the reformatting commit.

If files unrelated to your change were modified, try reverting the reformatting commit + merging with the target branch (and push those changes).

vs-mobiletools-engineering-service2 · 2025-04-28T15:20:30Z

✅ [CI Build #45b11cb] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 45b11cb3e2135101edf378fe9fc226df78e5c263 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-28T15:35:41Z

✅ [PR Build #45b11cb] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 45b11cb3e2135101edf378fe9fc226df78e5c263 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-28T16:14:24Z

✅ API diff for current PR / commit

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

.NET ( No breaking changes )

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ Generator diff

Generator diff is empty

Pipeline on Agent
Hash: 45b11cb3e2135101edf378fe9fc226df78e5c263 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-28T16:15:45Z

✅ [CI Build #45b11cb] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 45b11cb3e2135101edf378fe9fc226df78e5c263 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-28T16:27:53Z

💻 [CI Build #45b11cb] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 45b11cb3e2135101edf378fe9fc226df78e5c263 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-28T16:36:47Z

💻 [CI Build #45b11cb] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 45b11cb3e2135101edf378fe9fc226df78e5c263 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-28T16:37:28Z

💻 [CI Build #45b11cb] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 45b11cb3e2135101edf378fe9fc226df78e5c263 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-28T16:42:15Z

💻 [CI Build #45b11cb] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 45b11cb3e2135101edf378fe9fc226df78e5c263 [PR build]

vs-mobiletools-engineering-service2 · 2025-04-29T08:28:23Z

🚀 [CI Build #477104c] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 121 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 8 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 8 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 477104c7920730c0c891390a20a8bd214b8472ee [PR build]

mauroa added the not-notes-worthy Ignore for release notes label Apr 25, 2025

mauroa self-assigned this Apr 25, 2025

mauroa requested review from emaf and rolfbjarne as code owners April 25, 2025 01:52

mauroa requested review from Copilot, emaf and rolfbjarne and removed request for Copilot, emaf and rolfbjarne April 25, 2025 01:52

Copilot AI reviewed Apr 25, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

mauroa force-pushed the dev/maagno/main branch from 7e2ccc4 to cecf0b2 Compare April 25, 2025 04:02

mauroa force-pushed the dev/maagno/main branch from 5ea675f to c6a0109 Compare April 28, 2025 14:41

mauroa added 2 commits April 28, 2025 10:49

[xma][test] Augment RemoteTest to include validations over the output…

477104c

… files update logic

mauroa force-pushed the dev/maagno/main branch from a4ebe08 to 477104c Compare April 28, 2025 14:50

Auto-format source code

45b11cb

This comment has been minimized.

Sign in to view

rolfbjarne approved these changes Apr 29, 2025

View reviewed changes

rolfbjarne merged commit a0f9144 into main Apr 29, 2025
40 checks passed

rolfbjarne deleted the dev/maagno/main branch April 29, 2025 08:40

[xma] Added targets and tasks to copy modified dll and pdb files back to Windows #22677

[xma] Added targets and tasks to copy modified dll and pdb files back to Windows #22677

Uh oh!

Conversation

mauroa commented Apr 25, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

github-actions bot commented Apr 25, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Apr 28, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

github-actions bot commented Apr 28, 2025

⚠️ Your code has been reformatted. ⚠️

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 28, 2025

✅ [CI Build #45b11cb] Build passed (Build packages) ✅

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 28, 2025

✅ [PR Build #45b11cb] Build passed (Detect API changes) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 28, 2025

✅ API diff for current PR / commit

✅ API diff vs stable

✅ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 28, 2025

✅ [CI Build #45b11cb] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 28, 2025

💻 [CI Build #45b11cb] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 28, 2025

💻 [CI Build #45b11cb] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 28, 2025

💻 [CI Build #45b11cb] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 28, 2025

💻 [CI Build #45b11cb] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 29, 2025

🚀 [CI Build #477104c] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!