Skip to content

[SpriteKit] Fix all availability attributes in this framework. #22674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 4 commits into from
Apr 29, 2025
Merged

[SpriteKit] Fix all availability attributes in this framework. #22674

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
752fc93
[SpriteKit] Fix all availability attributes in this framework.
rolfbjarne Apr 24, 2025
fbb947f
Fix breaking change
rolfbjarne Apr 25, 2025
c885517
Merge remote-tracking branch 'origin/main' into dev/rolf/analyzer-spr…
rolfbjarne Apr 25, 2025
7c4b675
Merge remote-tracking branch 'origin/main' into dev/rolf/analyzer-spr…
rolfbjarne Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions runtime/bindings-generator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1151,6 +1151,19 @@ static IEnumerable<FunctionData> GetFunctionData ()
}
);

data.Add (
new FunctionData {
Comment = " // NativeHandle func (NativeHandleType, Vector2)",
Prefix = "simd__",
Variants = Variants.msgSend | Variants.msgSendSuper,
ReturnType = Types.NativeHandle,
Parameters = new ParameterData [] {
new ParameterData { TypeData = Types.NativeHandle },
new ParameterData { TypeData = Types.Vector2 },
},
}
);

data.Add (
new FunctionData {
Comment = " // IntPtr func (IntPtr, Vector2, Vector2); @try",
Expand Down
11 changes: 0 additions & 11 deletions src/SpriteKit/SKAction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,6 @@
#nullable enable

namespace SpriteKit {

#if !NET
[Obsolete ("Use 'SKActionTimingFunction2' instead.")]
public delegate void SKActionTimingFunction (float /* float, not CGFloat */ time);
#endif

public partial class SKAction {

/// <param name="size">To be added.</param>
Expand All @@ -31,10 +25,5 @@ public static SKAction ResizeTo (CGSize size, double duration)
{
return SKAction.ResizeTo (size.Width, size.Height, duration);
}

#if !NET
[Obsolete ("Use 'TimingFunction2' instead.")]
public virtual SKActionTimingFunction? TimingFunction { get; set; }
#endif
}
}
6 changes: 0 additions & 6 deletions src/SpriteKit/SKNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@

namespace SpriteKit {
public partial class SKNode : IEnumerable, IEnumerable<SKNode> {
#if NET
/// <typeparam name="T">To be added.</typeparam>
/// <param name="file">
///
Expand All @@ -33,7 +32,6 @@ public partial class SKNode : IEnumerable, IEnumerable<SKNode> {
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("tvos")]
#endif
public static T? FromFile<T> (string file) where T : SKNode
{
var fileHandle = CFString.CreateNative (file);
Expand Down Expand Up @@ -81,7 +79,6 @@ IEnumerator IEnumerable.GetEnumerator ()
return GetEnumerator ();
}

#if NET
/// <param name="filename">To be added.</param>
/// <param name="types">To be added.</param>
/// <param name="error">To be added.</param>
Expand All @@ -92,7 +89,6 @@ IEnumerator IEnumerable.GetEnumerator ()
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("maccatalyst")]
#endif
public static SKNode? Create (string filename, Type [] types, out NSError error)
{
// Let's fail early.
Expand All @@ -112,7 +108,6 @@ IEnumerator IEnumerable.GetEnumerator ()
}
}

#if NET
/// <param name="filename">To be added.</param>
/// <param name="classes">To be added.</param>
/// <param name="error">To be added.</param>
Expand All @@ -123,7 +118,6 @@ IEnumerator IEnumerable.GetEnumerator ()
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("maccatalyst")]
#endif
public static SKNode? Create (string filename, NSSet<Class> classes, out NSError error)
{
// `filename` will be checked by `Create` later
Expand Down
9 changes: 0 additions & 9 deletions src/SpriteKit/SKShapeNode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@

namespace SpriteKit {
public partial class SKShapeNode : SKNode {

#if NET
/// <param name="points">To be added.</param>
/// <summary>Creates a new shape node from the specified <paramref name="points" />.</summary>
/// <returns>To be added.</returns>
Expand All @@ -25,7 +23,6 @@ public partial class SKShapeNode : SKNode {
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("tvos")]
#endif
public static SKShapeNode FromPoints (CGPoint [] points)
{
if (points is null)
Expand All @@ -34,7 +31,6 @@ public static SKShapeNode FromPoints (CGPoint [] points)
return FromPoints (ref points [0], (nuint) points.Length);
}

#if NET
/// <param name="points">To be added.</param>
/// <param name="offset">To be added.</param>
/// <param name="length">To be added.</param>
Expand All @@ -45,7 +41,6 @@ public static SKShapeNode FromPoints (CGPoint [] points)
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("tvos")]
#endif
public static SKShapeNode FromPoints (CGPoint [] points, int offset, int length)
{
if (points is null)
Expand All @@ -56,7 +51,6 @@ public static SKShapeNode FromPoints (CGPoint [] points, int offset, int length)
return FromPoints (ref points [offset], (nuint) length);
}

#if NET
/// <param name="points">To be added.</param>
/// <summary>Creates a new shape node from the specified spline <paramref name="points" />.</summary>
/// <returns>To be added.</returns>
Expand All @@ -65,7 +59,6 @@ public static SKShapeNode FromPoints (CGPoint [] points, int offset, int length)
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("tvos")]
#endif
public static SKShapeNode FromSplinePoints (CGPoint [] points)
{
if (points is null)
Expand All @@ -74,7 +67,6 @@ public static SKShapeNode FromSplinePoints (CGPoint [] points)
return FromSplinePoints (ref points [0], (nuint) points.Length);
}

#if NET
/// <param name="points">To be added.</param>
/// <param name="offset">To be added.</param>
/// <param name="length">To be added.</param>
Expand All @@ -85,7 +77,6 @@ public static SKShapeNode FromSplinePoints (CGPoint [] points)
[SupportedOSPlatform ("macos")]
[SupportedOSPlatform ("maccatalyst")]
[SupportedOSPlatform ("tvos")]
#endif
public static SKShapeNode FromSplinePoints (CGPoint [] points, int offset, int length)
{
if (points is null)
Expand Down
Loading