Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/CoreMedia/CMSampleBuffer.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1054,6 +1054,10 @@ public bool? EndsPreviousSampleDuration {
/// <summary>To be added.</summary>
/// <value>To be added.</value>
/// <remarks>To be added.</remarks>
[SupportedOSPlatform ("ios")]
[SupportedOSPlatform ("maccatalyst")]
[UnsupportedOSPlatform ("macos")]
[SupportedOSPlatform ("tvos")]
public string? DroppedFrameReason {
get {
return GetStringValue (CMSampleAttachmentKey.DroppedFrameReason);
Expand Down
276 changes: 161 additions & 115 deletions src/CoreMedia/CMSync.cs

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions src/CoreMedia/CMTag.cs
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,10 @@ public bool IsValid {
public static CMTag ProjectionTypeEquirectangular { get => CMTagConstants.ProjectionTypeEquirectangular; }

/// <inheritdoc cref="CMTagConstants.ProjectionTypeHalfEquirectangular" />
[SupportedOSPlatform ("ios18.0")]
[SupportedOSPlatform ("tvos18.0")]
[SupportedOSPlatform ("maccatalyst18.0")]
[SupportedOSPlatform ("macos15.0")]
public static CMTag ProjectionTypeHalfEquirectangular { get => CMTagConstants.ProjectionTypeHalfEquirectangular; }

/// <inheritdoc cref="CMTagConstants.ProjectionTypeFisheye" />
Expand Down
4 changes: 4 additions & 0 deletions src/CoreMedia/NSValue.cs
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,10 @@ public static CMTimeMapping ToCMTimeMapping (NativeHandle handle)
/// </summary>
/// <param name="handle">The native handle.</param>
/// <returns>The CMTimeRange.</returns>
[SupportedOSPlatform ("ios16.0")]
[SupportedOSPlatform ("macos13.0")]
[SupportedOSPlatform ("maccatalyst16.0")]
[SupportedOSPlatform ("tvos16.0")]
public static CMVideoDimensions ToCMVideoDimensions (NativeHandle handle)
{
using var nsvalue = Runtime.GetNSObject<NSValue> (handle)!;
Expand Down
18 changes: 0 additions & 18 deletions tests/cecil-tests/ApiAvailabilityTest.KnownFailures.cs
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,6 @@
namespace Cecil.Tests {
public partial class ApiAvailabilityTest {
static HashSet<string> knownFailuresAvailabilityWarnings = new HashSet<string> {
"/src/CoreMedia/CMSampleBuffer.cs has 3 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CMSampleAttachmentKey.DroppedFrameReason.get' is supported on: 'ios', 'maccatalyst', 'tvos'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)",
"/src/CoreMedia/CMSync.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CMTimebase.CMTimebaseCopyMaster(nint)' is obsoleted on: 'ios' 9.0 and later (Use 'CMTimebaseGetMaster' instead.), 'macOS/OSX' 10.11 and later (Use 'CMTimebaseGetMaster' instead.), 'tvos' 9.0 and later (Use 'CMTimebaseGetMaster' instead.). (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)",
"/src/CoreMedia/CMSync.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CMTimebase.CMTimebaseCopyMasterClock(nint)' is obsoleted on: 'ios' 9.0 and later (Use 'CMTimebaseGetMasterClock' instead.), 'maccatalyst' 9.0 and later (Use 'CMTimebaseGetMasterClock' instead.), 'macOS/OSX' 10.11 and later (Use 'CMTimebaseGetMasterClock' instead.), 'tvos' 9.0 and later (Use 'CMTimebaseGetMasterClock' instead.). (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)",
"/src/CoreMedia/CMSync.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CMTimebase.CMTimebaseCopyMasterTimebase(nint)' is obsoleted on: 'ios' 9.0 and later (Use 'CMTimebaseGetMasterTimebase' instead.), 'macOS/OSX' 10.11 and later (Use 'CMTimebaseGetMasterTimebase' instead.), 'tvos' 9.0 and later (Use 'CMTimebaseGetMasterTimebase' instead.). (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)",
"/src/CoreMedia/CMSync.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CMTimebase.CMTimebaseCopyUltimateMasterClock(nint)' is obsoleted on: 'ios' 9.0 and later (Use 'CMTimebaseGetUltimateMasterClock' instead.), 'macOS/OSX' 10.11 and later (Use 'CMTimebaseGetUltimateMasterClock' instead.), 'tvos' 9.0 and later (Use 'CMTimebaseGetUltimateMasterClock' instead.). (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)",
"/src/CoreMedia/CMSync.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CMTimebase.CMTimebaseCreateWithMasterClock(nint, nint, nint*)' is obsoleted on: 'ios' 9.0 and later, 'maccatalyst' 9.0 and later, 'macOS/OSX' 10.10 and later, 'tvos' 9.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)",
"/src/CoreMedia/CMSync.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CMTimebase.CMTimebaseCreateWithMasterTimebase(nint, nint, nint*)' is obsoleted on: 'ios' 8.0 and later, 'maccatalyst' 8.0 and later, 'macOS/OSX' 10.10 and later, 'tvos' 9.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)",
"/src/CoreMedia/CMSync.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CMTimebase.CMTimebaseCreateWithSourceClock(nint, nint, nint*)' is supported on: 'ios' 15.0 and later, 'tvos' 15.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)",
"/src/CoreMedia/CMSync.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CMTimebase.CMTimebaseCreateWithSourceTimebase(nint, nint, nint*)' is supported on: 'ios' 15.0 and later, 'tvos' 15.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)",
"/src/CoreMedia/CMSync.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CMTimebase.CMTimebaseGetMaster(nint)' is obsoleted on: 'ios' 9.0 and later, 'maccatalyst' 9.0 and later, 'macOS/OSX' 10.11 and later, 'tvos' 9.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)",
"/src/CoreMedia/CMSync.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CMTimebase.CMTimebaseGetMasterClock(nint)' is obsoleted on: 'ios' 9.0 and later, 'maccatalyst' 9.0 and later, 'macOS/OSX' 10.10 and later, 'tvos' 9.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)",
"/src/CoreMedia/CMSync.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CMTimebase.CMTimebaseGetMasterClock(nint)' is obsoleted on: 'macOS/OSX' 10.10 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)",
"/src/CoreMedia/CMSync.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CMTimebase.CMTimebaseGetMasterTimebase(nint)' is obsoleted on: 'ios' 9.0 and later, 'maccatalyst' 9.0 and later, 'macOS/OSX' 10.10 and later, 'tvos' 9.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)",
"/src/CoreMedia/CMSync.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CMTimebase.CMTimebaseGetMasterTimebase(nint)' is obsoleted on: 'macOS/OSX' 10.10 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)",
"/src/CoreMedia/CMSync.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CMTimebase.CMTimebaseGetUltimateMasterClock(nint)' is obsoleted on: 'ios' 9.0 and later, 'maccatalyst' 9.0 and later, 'macOS/OSX' 10.11 and later, 'tvos' 9.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)",
"/src/CoreMedia/CMTag.cs has 4 occurrences of This call site is reachable on: 'ios' 17.0 and later, 'maccatalyst' 17.0 and later, 'macOS/OSX' 14.0 and later, 'tvos' 17.0 and later. 'CMTagConstants.ProjectionTypeHalfEquirectangular.get' is supported on: 'ios' 18.0 and later, 'maccatalyst' 18.0 and later, 'macOS/OSX' 15.0 and later, 'tvos' 18.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)",
"/src/CoreMedia/CMTag.cs has 4 occurrences of This call site is reachable on: 'ios' 17.0 and later, 'maccatalyst' 17.0 and later, 'macOS/OSX' 14.0 and later, 'tvos' 17.0 and later. 'CMTagConstants.ProjectionTypeHalfEquirectangular' is supported on: 'ios' 18.0 and later, 'maccatalyst' 18.0 and later, 'macOS/OSX' 15.0 and later, 'tvos' 18.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)",
"/src/CoreMedia/NSValue.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'NSValue.CMVideoDimensionsValue' is supported on: 'ios' 16.0 and later, 'maccatalyst' 16.0 and later, 'macOS/OSX' 13.0 and later, 'tvos' 16.0 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)",
"/src/CoreText/CTFont.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CTFontFeatureLetterCase' is obsoleted on: 'ios' 6.0 and later, 'maccatalyst' 6.0 and later, 'macOS/OSX' 10.7 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)",
"/src/CoreText/CTFont.cs has 4 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'FontFeatureGroup.LetterCase' is obsoleted on: 'ios' 6.0 and later, 'maccatalyst' 6.0 and later, 'macOS/OSX' 10.7 and later. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)",
"/src/CoreText/CTParagraphStyle.cs has 8 occurrences of This call site is reachable on: 'ios' 12.2 and later, 'maccatalyst' 12.2 and later, 'macOS/OSX' 12.0 and later, 'tvos' 12.2 and later. 'CTParagraphStyleSpecifier.LineSpacing' is obsoleted on: 'ios' 6.0 and later (Use 'MaximumLineSpacing' instead.), 'maccatalyst' 6.0 and later (Use 'MaximumLineSpacing' instead.), 'macOS/OSX' 10.8 and later (Use 'MaximumLineSpacing' instead.), 'tvos' 16.0 and later (Use 'MaximumLineSpacing' instead.). (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1422)",
Expand Down
2 changes: 1 addition & 1 deletion tests/cecil-tests/ApiAvailabilityTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public void Warnings ()
} finally {
Console.WriteLine ($"There's a total of {totalWarnings} warnings.");
}
Assert.AreEqual (884, totalWarnings, "Total warnings"); // this is just to see how the warning count changes as issues are fixed.
Assert.AreEqual (813, totalWarnings, "Total warnings"); // this is just to see how the warning count changes as issues are fixed.
}

public record ObsoletedFailure : IComparable {
Expand Down
1 change: 1 addition & 0 deletions tests/cecil-tests/Documentation.KnownFailures.txt
Original file line number Diff line number Diff line change
Expand Up @@ -21985,6 +21985,7 @@ M:CoreMedia.CMTimebase.AddTimer(Foundation.NSTimer,Foundation.NSRunLoop)
M:CoreMedia.CMTimebase.CopyMaster
M:CoreMedia.CMTimebase.CopyMasterClock
M:CoreMedia.CMTimebase.CopyMasterTimebase
M:CoreMedia.CMTimebase.CopySource
M:CoreMedia.CMTimebase.CopyUltimateMasterClock
M:CoreMedia.CMTimebase.GetMaster
M:CoreMedia.CMTimebase.GetMasterClock
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,3 @@
!unknown-pinvoke! CMTimebaseCreateWithMasterTimebase bound
!unknown-pinvoke! CMTimebaseSetMasterClock bound
!unknown-pinvoke! CMTimebaseSetMasterTimebase bound

# it can return a Clock or a Timebase but the API already has a way to access the clock source (CMTimebaseCopySourceClock)
# and the Timebase (CMTimebaseCopySourceTimebase) so there is no reason atm to add this method
!missing-pinvoke! CMTimebaseCopySource is not bound