Skip to content

Use Environment.SpecialFolder.UserProfile, not SpecialFolder.Personal. #16017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 2 commits into from
Sep 23, 2022
Merged

Use Environment.SpecialFolder.UserProfile, not SpecialFolder.Personal. #16017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
defc6be
Use Environment.SpecialFolder.UserProfile, not SpecialFolder.Personal.
rolfbjarne Sep 19, 2022
f6ceb36
Merge branch 'main' into no-more-personal-special-folder
rolfbjarne Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion msbuild/Xamarin.MacDev.Tasks/Tasks/ArchiveTaskBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ protected string MSYMDir {

protected string XcodeArchivesDir {
get {
var home = Environment.GetFolderPath (Environment.SpecialFolder.Personal);
var home = Environment.GetFolderPath (Environment.SpecialFolder.UserProfile);

return Path.Combine (home, "Library", "Developer", "Xcode", "Archives");
}
Expand Down
2 changes: 1 addition & 1 deletion tests/monotouch-test/Foundation/FileManagerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public void GetSkipBackupAttribute ()
{
Assert.False (NSFileManager.GetSkipBackupAttribute (NSBundle.MainBundle.ExecutableUrl.ToString ()), "MainBundle");

string filename = Path.Combine (Environment.GetFolderPath (Environment.SpecialFolder.Personal), $"DoNotBackupMe-NSFileManager-{Process.GetCurrentProcess ().Id}");
string filename = Path.Combine (Environment.GetFolderPath (Environment.SpecialFolder.UserProfile), $"DoNotBackupMe-NSFileManager-{Process.GetCurrentProcess ().Id}");
try {
File.WriteAllText (filename, "not worth a bit");

Expand Down
2 changes: 1 addition & 1 deletion tests/monotouch-test/Foundation/UrlTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ public void IsExcludedFromBackupKey ()
Assert.That (value, Is.TypeOf (typeof (NSNumber)), "NSNumber");
Assert.That ((int) (value as NSNumber), Is.EqualTo (0), "0");

string filename = Path.Combine (Environment.GetFolderPath (Environment.SpecialFolder.Personal), $"DoNotBackupMe-NSUrl-{Process.GetCurrentProcess ().Id}");
string filename = Path.Combine (Environment.GetFolderPath (Environment.SpecialFolder.UserProfile), $"DoNotBackupMe-NSUrl-{Process.GetCurrentProcess ().Id}");
try {
File.WriteAllText (filename, "not worth a bit");
using (NSUrl url = NSUrl.FromFilename (filename)) {
Expand Down
2 changes: 1 addition & 1 deletion tools/common/Driver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,7 @@ static Driver ()
static int GetDefaultVerbosity ()
{
var v = 0;
var fn = Path.Combine (Environment.GetFolderPath (Environment.SpecialFolder.Personal), $".{NAME}-verbosity");
var fn = Path.Combine (Environment.GetFolderPath (Environment.SpecialFolder.UserProfile), $".{NAME}-verbosity");
if (File.Exists (fn)) {
v = (int) new FileInfo (fn).Length;
if (v == 0)
Expand Down
2 changes: 1 addition & 1 deletion tools/devops/mac-tests-provisioning.csx.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ if (!string.IsNullOrEmpty ("@INCLUDE_XAMARIN_LEGACY@")) {

BrewPackages ("p7zip");

var appleSdkOverride = Path.Combine (Environment.GetFolderPath (Environment.SpecialFolder.Personal), "Library", "Preferences", "Xamarin", "Settings.plist");
var appleSdkOverride = Path.Combine (Environment.GetFolderPath (Environment.SpecialFolder.UserProfile), "Library", "Preferences", "Xamarin", "Settings.plist");
Item ("Override Apple SDK Settings")
.Condition (item => !File.Exists (appleSdkOverride) || GetSettingValue (appleSdkOverride, "AppleSdkRoot") != GetSelectedXcodePath ())
.Action (item => {
Expand Down