[msbuild] Refactor the logic to compute the target devices for IBTool/ACTool. #12461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/ACTool. Refactor the logic to compute the target devices for IBTool/ACTool, so that it doesn't depend on the existence of the input app manifest, but instead uses values that either comes from the app manifest, or have a default. This becomes an important distinction when we add support for multiple partial app manifests, or none at all (where all the required values come from MSBuild properties).
rolfbjarne
added
not-notes-worthy
spouliot
approved these changes
Aug 17, 2021
dalexsoto
approved these changes
Aug 17, 2021
mandel-macaque
approved these changes
Aug 17, 2021
Collaborator
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diff✅ API Diff (from PR only) (no change) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results1 tests failed, 137 tests passed.Failed tests
Pipeline on Agent XAMBOT-1098.BigSur' |
Member
Author
|
Test failure is unrelated (will be fixed with #12470). |
emaf
approved these changes
Aug 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the logic to compute the target devices for IBTool/ACTool, so that it
doesn't depend on the existence of the input app manifest, but instead uses
values that either comes from the app manifest, or have a default.
This becomes an important distinction when we add support for multiple partial
app manifests, or none at all (where all the required values come from MSBuild
properties).