[compare-commits] Rework logic to build xamarin-macios again from a separate clone. #10264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eparate clone. Rework the code to generate an API comparison and a generator comparison: we now clone xamarin-macios into a different directory, checks out the hash we want to compare against, build the whole thing, and then compare the results. This is somewhat slower than the previous implementation (which would checkout the previous hash and build that on top of the existing build), but since we don't have to build mono, it shouldn't make too much of a difference (the biggest chunk of our build is building src/, and we had to do that anyway with the previous implementation as well). The upside is that it should be much more reliable. Fixes xamarin/maccore#2034. Fixes xamarin/maccore#1467. Fixes xamarin/maccore#1059. Maybe xamarin/maccore#1173 too.
rolfbjarne
added
not-notes-worthy
dalexsoto
approved these changes
Dec 11, 2020
|
Build failure |
spouliot
approved these changes
Dec 11, 2020
|
Build success |
tj-devel709
approved these changes
Dec 11, 2020
mandel-macaque
approved these changes
Dec 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework the code to generate an API comparison and a generator comparison: we
now clone xamarin-macios into a different directory, checks out the hash we
want to compare against, build the whole thing, and then compare the results.
This is somewhat slower than the previous implementation (which would checkout
the previous hash and build that on top of the existing build), but since we
don't have to build mono, it shouldn't make too much of a difference (the
biggest chunk of our build is building src/, and we had to do that anyway with
the previous implementation as well).
The upside is that it should be much more reliable.
Fixes https://github.com/xamarin/maccore/issues/2034.
Fixes https://github.com/xamarin/maccore/issues/1467.
Fixes https://github.com/xamarin/maccore/issues/1059.
Maybe https://github.com/xamarin/maccore/issues/1173 too.