Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mlaunch] Adjust build logic to ship mlaunch with the .NET nugets when we're building mlaunch as well. #10122

Merged
merged 1 commit into from
Nov 20, 2020
Merged

[mlaunch] Adjust build logic to ship mlaunch with the .NET nugets when we're building mlaunch as well. #10122

merged 1 commit into from
Nov 20, 2020

Conversation

rolfbjarne
Copy link
Member

The original implementation only worked when we used mlaunch from the
macios-binaries repository.

@rolfbjarne
[mlaunch] Adjust build logic to ship mlaunch with the .NET nugets whe…
f9dbccc 
…n we're building mlaunch as well.

The original implementation only worked when we used mlaunch from the
macios-binaries repository.
@rolfbjarne rolfbjarne added not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests labels Nov 20, 2020
@rolfbjarne rolfbjarne mentioned this pull request Nov 20, 2020
Merged
@monojenkins
Copy link
Collaborator

Build success
✅ Provisioning succeeded
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded

@rolfbjarne rolfbjarne merged commit 3174e94 into dotnet:main Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spouliot spouliot spouliot approved these changes

Assignees
No one assigned
Labels
not-notes-worthy Ignore for release notes run-dotnet-tests Run all the .NET tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rolfbjarne @monojenkins @spouliot