Improve unique directory generation for temp files #7520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor unique directory creation logic to use random file names.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the unique directory creation logic for temporary files to use random file names instead of incrementing directory numbers. The change replaces a counter-based approach with a random filename approach to generate unique temporary directory names.
- Replaces incremental directory numbering with random filename generation
- Simplifies the directory creation loop logic
- Updates the directory naming pattern from
ml_dotnet{number}toml_dotnet_{randomfilename}
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
tarekgh
approved these changes
Oct 3, 2025
Member
Author
|
/backport to release/4.0 |
Contributor
|
Started backporting to release/4.0: https://github.com/dotnet/machinelearning/actions/runs/18728685429 |
This was referenced Nov 11, 2025
This was referenced Nov 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor unique directory creation logic to use random file names.
Fixes #7485