-
Notifications
You must be signed in to change notification settings - Fork 1.9k
macOS x64 CI: fix dependency install and OpenMP runtime copy (use Homebrew libomp, adjust Helix payload) #7510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Commenter does not have sufficient privileges for PR 7510 in repo dotnet/machinelearning |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7510 +/- ##
==========================================
- Coverage 69.01% 69.00% -0.01%
==========================================
Files 1482 1482
Lines 273999 273999
Branches 28258 28258
==========================================
- Hits 189093 189075 -18
- Misses 77520 77536 +16
- Partials 7386 7388 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Commenter does not have sufficient privileges for PR 7510 in repo dotnet/machinelearning |
6c0c6a4 to
47bb847
Compare
e44de68 to
eb0ee80
Compare
…ustom formula path
eb0ee80 to
d282b6a
Compare
|
I really need these changes, thanks! |
|
I tried to simplify a bit where x64 and M1 were the same. Let's see if this will also resolve the M1 failure. |
|
/ba-g Mac-OS unrelated failures |
f0ce5ba to
1390b39
Compare
…ebrew libomp, adjust Helix payload) (#7510) * CI(macOS x64): use Homebrew libomp + copy only libomp.dylib; remove custom formula path * Fix indenting and make M1 and x64 consistent * Simplify helix.proj --------- Co-authored-by: Eric StJohn <[email protected]>
* Update dependencies from https://github.com/dotnet/arcade build 20250516.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25266.2 * update cmake mac (#7443) * update cmake mac * cmake specific version * remove specific version * cmake policy version minimum * Update build/ci/job-template.yml * Try adding -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to libomp.rb * Update job-template.yml * Update cmake_minimum_required --------- Co-authored-by: Eric StJohn <[email protected]> * Update dependencies from https://github.com/dotnet/arcade build 20250521.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25271.1 * Update dependencies from https://github.com/dotnet/arcade build 20250602.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25302.2 * Update dependencies from https://github.com/dotnet/arcade build 20250625.4 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25325.4 * Update dependencies from https://github.com/dotnet/arcade build 20250716.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25366.1 * Update dependencies from https://github.com/dotnet/arcade build 20250730.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25380.1 * Update dependencies from https://github.com/dotnet/arcade build 20250807.2 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25407.2 * Update dependencies from https://github.com/dotnet/arcade build 20250815.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25415.3 * Update dependencies from https://github.com/dotnet/arcade build 20250828.3 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25428.3 * Update dependencies from https://github.com/dotnet/arcade build 20250910.1 Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25460.1 * Update dependencies from https://github.com/dotnet/arcade build 20250912.4 On relative base path root Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25462.4 * Update dependencies from https://github.com/dotnet/arcade build 20250915.2 On relative base path root Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25465.2 * Update dependencies from https://github.com/dotnet/arcade build 20250923.2 On relative base path root Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25473.2 * Update dependencies from https://github.com/dotnet/arcade build 20250925.3 On relative base path root Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25475.3 * Update dependencies from https://github.com/dotnet/arcade build 20251003.3 On relative base path root Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25503.3 * Update dependencies from https://github.com/dotnet/arcade build 20251015.2 On relative base path root Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.25111.5 -> To Version 9.0.0-beta.25515.2 * macOS x64 CI: fix dependency install and OpenMP runtime copy (use Homebrew libomp, adjust Helix payload) (#7510) * CI(macOS x64): use Homebrew libomp + copy only libomp.dylib; remove custom formula path * Fix indenting and make M1 and x64 consistent * Simplify helix.proj --------- Co-authored-by: Eric StJohn <[email protected]> * Update Windows image, fix mac build (#7515) * Fix new compilation errors with latest SDK * Fix additional breaks introduced with new SDK * Update Helix ubuntu arm32 container (#7410) * Update Helix ubuntu arm32 container * Switch to debian-12-helix-arm32v7 * Revert back to ubuntu-24.04-helix-arm32v7 * Update helixQueue to use Ubuntu 22.04 on ARM32 * Add linux-arm baseline for Summarize.txt --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Michael Sharp <[email protected]> Co-authored-by: Eric StJohn <[email protected]> Co-authored-by: Alexey Sokolov <[email protected]>
PR: macOS x64 CI: fix dependency install and OpenMP runtime copy
Summary
This PR fixes MachineLearning-CI failures on macOS x64 where jobs stop at Install MacOS build dependencies with:
The breakage comes from two areas:
libomp.rbpath that no longer works on hosted macOS images.libomp.dylibandlibiomp5.dylib, butlibiomp5.dylibis not available when installinglibompfrom Homebrew core.Fixes #7509
Changes
build/ci/job-template.ymlbrew install …/build/libomp.rbwith standard Homebrew:eng/helix.projDYLD_LIBRARY_PATHso Helix can findlibomp.dylib./usr/local/opt/libomp/lib/libomp.dylibinto the publish folder.libiomp5.dylib(not present withlibompfrom Homebrew).@loader_path/libomp.dylib.Why
libompis available via core.Testing
osx.13.amd64.openqueue.libomp.dylibis present in publish folder.DYLD_LIBRARY_PATHset correctly.Risk / Impact
Additional Notes
llvmoverlibompas the OpenMP provider, happy to adjust.PR Checklist