Skip to content

Update dependencies from maintenance-packages #7412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelgsharp merged 6 commits into from
Mar 7, 2025
Merged

Update dependencies from maintenance-packages #7412

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aa63364
Feed
carlossanlop Mar 6, 2025
40e4e6c
Update System.Memory and System.Runtime.CompilerServices.Unsafe
carlossanlop Mar 6, 2025
586c37a
Remove NU1603 suppression out of curiosity.
carlossanlop Mar 6, 2025
1353aed
Update NuGet.config
carlossanlop Mar 6, 2025
63dc1c0
remove NU1603 and comment too.
carlossanlop Mar 6, 2025
ffd7887
Add new package source mapping entry
michaelgsharp Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NuGet.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
</solution>
<packageSources>
<clear />
<add key="darc-pub-dotnet-maintenance-packages-ab95a1f1" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-maintenance-packages-ab95a1f1/nuget/v3/index.json" />
Comment thread
carlossanlop marked this conversation as resolved.
Outdated
<add key="dotnet-public" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-public/nuget/v3/index.json" />
<add key="dotnet-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json" />
<add key="dotnet-libraries" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-libraries/nuget/v3/index.json" />
Expand Down
4 changes: 2 additions & 2 deletions eng/Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@
<SystemConfigurationConfigurationManagerVersion>6.0.1</SystemConfigurationConfigurationManagerVersion>
<SystemFormatsAsn1Version>8.0.1</SystemFormatsAsn1Version>
<SystemIOFileSystemAccessControl>5.0.0</SystemIOFileSystemAccessControl>
<SystemMemoryVersion>4.6.0</SystemMemoryVersion>
<SystemMemoryVersion>4.6.1</SystemMemoryVersion>
<SystemNumericsTensorsVersion>9.0.0</SystemNumericsTensorsVersion>
<SystemReflectionEmitLightweightVersion>4.7.0</SystemReflectionEmitLightweightVersion>
<SystemReflectionEmitVersion>4.3.0</SystemReflectionEmitVersion>
<SystemRuntimeCompilerServicesUnsafeVersion>6.1.0</SystemRuntimeCompilerServicesUnsafeVersion>
<SystemRuntimeCompilerServicesUnsafeVersion>6.1.1</SystemRuntimeCompilerServicesUnsafeVersion>
<SystemSecurityPrincipalWindows>5.0.0</SystemSecurityPrincipalWindows>
<SystemTextEncodingsWebVersion>8.0.0</SystemTextEncodingsWebVersion>
<SystemTextJsonVersion>8.0.5</SystemTextJsonVersion>
Expand Down
2 changes: 1 addition & 1 deletion test/Microsoft.ML.FSharp.Tests/Microsoft.ML.FSharp.Tests.fsproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
.NET Framework 4.6.1 includes System.ValueTuple without a version, so we need to ignore the warning here.
Bug in the latest version of VS points to a Version of FSharp.Core that doesn't exist. Temporarily ignoring
NU1603 so it will use the latest version found.-->
<NoWarn>NU1603;NU1604;2003;$(NoWarn)</NoWarn>
<NoWarn>NU1604;2003;$(NoWarn)</NoWarn>

@carlossanlop carlossanlop Mar 6, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an error related to System.ValueTuple, which we updated in maintenance-packages too. I am merely curious about the failure and want to see it happening. I couldn't get it to repro locally.

@ericstj ericstj Mar 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the NU1603 was for a version of FSharp.Core referenced by VS provided targets for fsproj, not ValueTuple. I think those targets referenced a version which wasn't available on our feeds. If we hit that again we should just make sure to mirror the version it's using to dotnet-public feed.

Looks like NU1604 was for value tuple 791e37e#diff-5c7e38da31722117952bacf9106591b3ec142e24b114c5172f5d634f9bce21d1R3-R5
Which would have been caused by an old version of FSharp that referenced ValueTuple from their nuspec without listing a version. dotnet/fsharp#12778

I bet both have been fixed now, so lets try removing them both.

<PublicSign>false</PublicSign>
<SourceLink></SourceLink>
<PlatformTarget>$(TargetArchitecture)</PlatformTarget>
Expand Down