Skip to content

Conversation

@Youssef1313
Copy link
Member

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

@codecov
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.89%. Comparing base (886e2ff) to head (766060f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7349   +/-   ##
=======================================
  Coverage   68.88%   68.89%           
=======================================
  Files        1473     1473           
  Lines      270771   270771           
  Branches    27884    27884           
=======================================
+ Hits       186529   186543   +14     
+ Misses      76970    76959   -11     
+ Partials     7272     7269    -3     
Flag Coverage Δ
Debug 68.89% <ø> (+<0.01%) ⬆️
production 63.21% <ø> (+<0.01%) ⬆️
test 89.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@michaelgsharp
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@michaelgsharp michaelgsharp merged commit 0ea7303 into dotnet:main Jan 13, 2025
25 checks passed
@Youssef1313 Youssef1313 deleted the patch-2 branch January 13, 2025 20:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants