Enable APICompat for non-stable projects #7340
Conversation
|
Need to mirror these to dotnet-public. Doing so, then will rerun. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
GetSortIndices was accidentally regressed in the last release.��This compat suppression is permitting the fix for that regression.
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> | ||
| <Target>M:Microsoft.ML.GenAI.Core.CausalLMModelInput.#ctor(TorchSharp.torch.Tensor,TorchSharp.torch.Tensor,TorchSharp.torch.Tensor,System.Int32,TorchSharp.torch.Tensor,System.Boolean,System.Boolean,System.Boolean)</Target> |
There was a problem hiding this comment.
@LittleLittleCloud @stephentoub are these intentional breaking changes over last release?
Let me know if you'd prefer we not do API compat for this lib if you intend to make lots of breaking changes like this.
There was a problem hiding this comment.
@ericstj I'd prefer to skip API compat change for all ML.NET GenAI libraries? How to do it with ease :)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7340 +/- ##
==========================================
+ Coverage 68.88% 68.93% +0.04%
==========================================
Files 1473 1473
Lines 270771 271075 +304
Branches 27884 27946 +62
==========================================
+ Hits 186518 186855 +337
+ Misses 76979 76955 -24
+ Partials 7274 7265 -9
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
| <!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids --> | ||
| <Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema"> | ||
| <Suppression> | ||
| <DiagnosticId>CP0002</DiagnosticId> |
There was a problem hiding this comment.
@LittleLittleCloud more GenAI suppressions to look at.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Not a strong desire for this. Folks can run this manually if they want. |
Should help folks avoid problems like #7331