-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Arrow Timestamp and Date32 in DataFrame #7262
base: main
Are you sure you want to change the base?
Conversation
@dotnet-policy-service agree |
FYI @asmirnov82 |
c370a14
to
198834c
Compare
Timestamp contains UTC information so it makes sense to capture it in `DateTimeOffset` rather than `DateTime`. Also, capture `Date32` as a `DateOnly` if we're in .NET 6 (`DateOnly` is missing from .NET standard at this point).
198834c
to
ebc6811
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7262 +/- ##
==========================================
+ Coverage 68.78% 68.85% +0.06%
==========================================
Files 1463 1474 +11
Lines 272288 274195 +1907
Branches 28177 28423 +246
==========================================
+ Hits 187300 188791 +1491
- Misses 77748 78084 +336
- Partials 7240 7320 +80
Flags with carried forward coverage won't be shown. Click here to find out more.
|
I think I'm happy with the coverage report. The lines that matter are covered. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor changes but otherwise looks good to me.
Thank you very much for the quick review @michaelgsharp ! I've added a few replies to your comments to help figure out the best course of action before proceeding with this. |
Hi @michaelgsharp, would you mind having another look at this? |
Hi @michaelgsharp , would you be able to have a look at this? |
@michaelgsharp could you have another look? I addressed all of your comments so should be straightforward to review. |
b626e57
to
13ce456
Compare
Fixes: #7260
Fixes: #7261
Timestamp contains UTC information so it makes sense to capture it in
DateTimeOffset
rather thanDateTime
.Also, capture
Date32
as aDateOnly
if we're in .NET 6 (DateOnly
is missing from .NET standard at this point).We are excited to review your PR.
So we can do the best job, please check:
Fixes #nnnn
in your description to cause GitHub to automatically close the issue(s) when your PR is merged.