Skip to content

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 7, 2022

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 1c26c342-7dbd-4e18-3778-08daa2f83374
  • Build: 20221108.4
  • Date Produced: November 8, 2022 7:03:36 PM UTC
  • Commit: 3f3c360819c5c092d0e4505a67dfe59a33fba557
  • Branch: refs/heads/release/7.0
  • Updates to .NET SDKs:
    • Updates tools.dotnet to 7.0.100

…031.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
 From Version 7.0.0-beta.22514.3 -> To Version 7.0.0-beta.22531.4
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #6439 (641f624) into main (025e373) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6439      +/-   ##
==========================================
+ Coverage   68.50%   68.54%   +0.03%     
==========================================
  Files        1170     1170              
  Lines      246977   246977              
  Branches    25792    25792              
==========================================
+ Hits       169187   169285      +98     
+ Misses      71045    70973      -72     
+ Partials     6745     6719      -26     
Flag Coverage Δ
Debug 68.54% <ø> (+0.03%) ⬆️
production 62.94% <ø> (+0.05%) ⬆️
test 88.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.ML.DataView/VBufferEditor.cs 96.87% <ø> (ø)
src/Microsoft.ML.Core/Data/ProgressReporter.cs 70.95% <0.00%> (-6.99%) ⬇️
src/Microsoft.ML.FastTree/Dataset/DenseIntArray.cs 40.09% <0.00%> (-4.30%) ⬇️
src/Microsoft.ML.Maml/MAML.cs 24.36% <0.00%> (-2.54%) ⬇️
...ML.Transforms/Text/StopWordsRemovingTransformer.cs 86.53% <0.00%> (+0.14%) ⬆️
src/Microsoft.ML.Data/Utils/LossFunctions.cs 67.35% <0.00%> (+0.51%) ⬆️
...oft.ML.StandardTrainers/Standard/SdcaMulticlass.cs 92.49% <0.00%> (+1.02%) ⬆️
...soft.ML.Transforms/Text/WordEmbeddingsExtractor.cs 86.87% <0.00%> (+1.13%) ⬆️
src/Microsoft.ML.Sweeper/AsyncSweeper.cs 72.78% <0.00%> (+1.36%) ⬆️
...crosoft.ML.StandardTrainers/Standard/SdcaBinary.cs 88.82% <0.00%> (+3.41%) ⬆️
... and 2 more

…108.4

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild , Microsoft.DotNet.XUnitExtensions
 From Version 7.0.0-beta.22514.3 -> To Version 7.0.0-beta.22558.4
@ericstj
Copy link
Member

ericstj commented Nov 9, 2022

This PR is updating Arcade and moving us to the GA toolchain. I'm surprised to see this error, I thought roslyn fixed this in 7.0 GA.

D:\a\_work\1\s\src\Microsoft.ML.Core\Utilities\VBufferUtils.cs(1200,51): error CS9077: Cannot return a parameter by reference 'dst' through a ref parameter; it can only be returned in a return statement [D:\a\_work\1\s\src\Microsoft.ML.Core\Microsoft.ML.Core.csproj]
D:\a\_work\1\s\src\Microsoft.ML.Core\Utilities\VBufferUtils.cs(1200,26): error CS8347: Cannot use a result of 'VBufferEditor.Create<TDst>(ref VBuffer<TDst>, int, int?, int?, bool, bool)' in this context because it may expose variables referenced by parameter 'destination' outside of their declaration scope [D:\a\_work\1\s\src\Microsoft.ML.Core\Microsoft.ML.Core.csproj]
D:\a\_work\1\s\src\Microsoft.ML.Core\Utilities\VBufferUtils.cs(1253,47): error CS9077: Cannot return a parameter by reference 'dst' through a ref parameter; it can only be returned in a return statement [D:\a\_work\1\s\src\Microsoft.ML.Core\Microsoft.ML.Core.csproj]
D:\a\_work\1\s\src\Microsoft.ML.Core\Utilities\VBufferUtils.cs(1253,22): error CS8347: Cannot use a result of 'VBufferEditor.Create<TDst>(ref VBuffer<TDst>, int, int?, int?, bool, bool)' in this context because it may expose variables referenced by parameter 'destination' outside of their declaration scope [D:\a\_work\1\s\src\Microsoft.ML.Core\Microsoft.ML.Core.csproj]

Having a look.

This prevents errors CS9077 and CS8347 which are raised where the
compiler cannot determine if the reference parameter destination is
leaked.
@ericstj ericstj force-pushed the darc-main-91df02bd-3551-48e5-9bea-7340627717cc branch from 2507b61 to 641f624 Compare November 9, 2022 22:19
@ericstj ericstj merged commit 87337c0 into main Nov 11, 2022
@dotnet-maestro dotnet-maestro bot deleted the darc-main-91df02bd-3551-48e5-9bea-7340627717cc branch November 11, 2022 15:25
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants