Use Equals and = operator for DataViewType comparison#5942
Merged
michaelgsharp merged 1 commit intodotnet:mainfrom Oct 1, 2021
thoron:main
Merged
Use Equals and = operator for DataViewType comparison#5942michaelgsharp merged 1 commit intodotnet:mainfrom thoron:main
michaelgsharp merged 1 commit intodotnet:mainfrom
thoron:main
Conversation
DataViewType of Vector<T, NN> would not evaluate correctly and Vector types which was of same types and sizes would fail for AutoML. Fixes #5773
michaelgsharp
approved these changes
Oct 1, 2021
Contributor
michaelgsharp
left a comment
michaelgsharp
left a comment
There was a problem hiding this comment.
Thanks for making this update. LGTM.
We had an issue with the code coverage not uploading correctly. It has been fixed, so I'll see if a fresh run of the pipelines will get the change. If not, you will need to rebase on main.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov Report
@@ Coverage Diff @@
## main #5942 +/- ##
==========================================
+ Coverage 68.19% 68.20% +0.01%
==========================================
Files 1142 1142
Lines 242367 242534 +167
Branches 25355 25378 +23
==========================================
+ Hits 165282 165430 +148
- Misses 70406 70407 +1
- Partials 6679 6697 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands on the
DataViewTypeequals comparison to allow for advanced types to be used. Currently columns of typeVector<T, NN>does to work as the comparison will fail. The Equals implementation inVectorDataViewTypedoes account for thePrimitiveDataViewTypeand dimension sizes.The method chosen simply expands on the current comparsion and adds Equals to it.
The code has not been tested using the existing test suits as I could not get them to run locally.
This PR also contains two style fixes, shown as errors in VS (automatically fixed).
Fixes #5773