Init _bestMetricValue for Loss metric#5939
Merged
michaelgsharp merged 1 commit intodotnet:mainfrom Oct 5, 2021
MiroslavKabat:main
Merged
Init _bestMetricValue for Loss metric#5939michaelgsharp merged 1 commit intodotnet:mainfrom MiroslavKabat:main
michaelgsharp merged 1 commit intodotnet:mainfrom
MiroslavKabat:main
Conversation
_bestMetricValue must be initialized with Single.MaxValue for Loss metric
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
michaelgsharp
approved these changes
Oct 4, 2021
Contributor
michaelgsharp
left a comment
michaelgsharp
left a comment
There was a problem hiding this comment.
LGTM. I restarted the CI process, so I'll merge it in when its done.
Codecov Report
@@ Coverage Diff @@
## main #5939 +/- ##
==========================================
+ Coverage 68.19% 68.23% +0.04%
==========================================
Files 1142 1142
Lines 242367 242802 +435
Branches 25355 25385 +30
==========================================
+ Hits 165282 165682 +400
- Misses 70406 70425 +19
- Partials 6679 6695 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_bestMetricValue must be initialized with Single.MaxValue for Loss metric because is decreasing over training.
Fixes #5938