Ensure the named model is loaded#5833
Merged
michaelgsharp merged 1 commit intodotnet:mainfrom Jun 3, 2021
feiyun0112:patch15
Merged
Ensure the named model is loaded#5833michaelgsharp merged 1 commit intodotnet:mainfrom feiyun0112:patch15
michaelgsharp merged 1 commit intodotnet:mainfrom
feiyun0112:patch15
Conversation
Crabzmatic
reviewed
Jun 3, 2021
| using System.IO; | ||
| using System.Threading; | ||
| using Microsoft.Extensions.DependencyInjection; | ||
| using Microsoft.Extensions.Logging; |
Contributor
There was a problem hiding this comment.
Looks good!
I think you have some redundant imports here.
Codecov Report
@@ Coverage Diff @@
## main #5833 +/- ##
==========================================
+ Coverage 68.32% 68.36% +0.03%
==========================================
Files 1131 1132 +1
Lines 241291 241313 +22
Branches 25053 25054 +1
==========================================
+ Hits 164863 164970 +107
+ Misses 69923 69839 -84
+ Partials 6505 6504 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
michaelgsharp
approved these changes
Jun 3, 2021
Contributor
michaelgsharp
left a comment
michaelgsharp
left a comment
There was a problem hiding this comment.
Looks good! Thanks for the submission.
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5831