Skip to content

Bug fix: Use return value of method#5818

Merged
michaelgsharp merged 2 commits intodotnet:mainfrom
feiyun0112:patch6
Jun 8, 2021
Merged

Bug fix: Use return value of method#5818
michaelgsharp merged 2 commits intodotnet:mainfrom
feiyun0112:patch6

Conversation

@feiyun0112
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #5818 (c79ea25) into main (7c34ab9) will decrease coverage by 0.04%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main    #5818      +/-   ##
==========================================
- Coverage   68.37%   68.33%   -0.05%     
==========================================
  Files        1131     1131              
  Lines      241291   241291              
  Branches    25053    25053              
==========================================
- Hits       164993   164877     -116     
- Misses      69806    69910     +104     
- Partials     6492     6504      +12     
Flag Coverage Δ
Debug 68.33% <50.00%> (-0.05%) ⬇️
production 62.94% <50.00%> (-0.07%) ⬇️
test 89.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Microsoft.ML.TimeSeries/RootCauseAnalyzer.cs 57.36% <0.00%> (ø)
...soft.ML.Data/Transforms/GenerateNumberTransform.cs 84.94% <100.00%> (+3.86%) ⬆️
...osoft.ML.KMeansClustering/KMeansPlusPlusTrainer.cs 83.60% <0.00%> (-7.16%) ⬇️
src/Microsoft.ML.Data/Training/TrainerUtils.cs 65.86% <0.00%> (-3.82%) ⬇️
....ML.AutoML/PipelineSuggesters/PipelineSuggester.cs 78.74% <0.00%> (-3.15%) ⬇️
...crosoft.ML.StandardTrainers/Standard/SdcaBinary.cs 85.49% <0.00%> (-3.08%) ⬇️
src/Microsoft.ML.Sweeper/AsyncSweeper.cs 71.42% <0.00%> (-1.37%) ⬇️
...crosoft.ML.StandardTrainers/Optimizer/Optimizer.cs 71.96% <0.00%> (-1.16%) ⬇️
...oft.ML.StandardTrainers/Standard/SdcaMulticlass.cs 91.46% <0.00%> (-1.03%) ⬇️
src/Microsoft.ML.Data/Utils/LossFunctions.cs 66.83% <0.00%> (-0.52%) ⬇️
... and 5 more

Copy link
Contributor

@michaelgsharp michaelgsharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelgsharp michaelgsharp merged commit 51b134a into dotnet:main Jun 8, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants