Remove never executed codes#5808
Merged
michaelgsharp merged 2 commits intodotnet:mainfrom Jun 8, 2021
feiyun0112:patch2
Merged
Remove never executed codes#5808michaelgsharp merged 2 commits intodotnet:mainfrom feiyun0112:patch2
michaelgsharp merged 2 commits intodotnet:mainfrom
feiyun0112:patch2
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5808 +/- ##
==========================================
+ Coverage 68.32% 68.41% +0.09%
==========================================
Files 1131 1134 +3
Lines 241291 241929 +638
Branches 25053 25109 +56
==========================================
+ Hits 164863 165521 +658
+ Misses 69923 69890 -33
- Partials 6505 6518 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
michaelgsharp
suggested changes
Jun 8, 2021
Contributor
michaelgsharp
left a comment
There was a problem hiding this comment.
Everything looks fine except the paths one. I added a comment directly on it.
michaelgsharp
approved these changes
Jun 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
condition always true