Fix erroneous use of TaskContinuationOptions in ThreadUtils.cs#5753
Merged
michaelgsharp merged 1 commit intodotnet:mainfrom May 4, 2021
Merged
Fix erroneous use of TaskContinuationOptions in ThreadUtils.cs#5753michaelgsharp merged 1 commit intodotnet:mainfrom
michaelgsharp merged 1 commit intodotnet:mainfrom
Conversation
This was supposed to be TaskCreationOptions.
sharwell
approved these changes
Apr 20, 2021
Codecov Report
@@ Coverage Diff @@
## main #5753 +/- ##
==========================================
+ Coverage 68.38% 68.41% +0.03%
==========================================
Files 1131 1131
Lines 241019 241217 +198
Branches 25024 25071 +47
==========================================
+ Hits 164822 165032 +210
+ Misses 69714 69702 -12
Partials 6483 6483
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was supposed to be TaskCreationOptions. TaskContinuationOptions here will end up binding to the wrong ctor, and won't actually have the desired effect, which is to avoid blocking the thread completing this TCS.
Thanks @sharwell for flagging it with CA2247.