Skip to content
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions build/ci/job-template.yml
Original file line number Diff line number Diff line change
Expand Up @@ -148,16 +148,6 @@ jobs:
- script: $(dotnetPath) msbuild -restore build/Codecoverage.proj
displayName: Upload coverage to codecov.io
condition: and(succeeded(), eq(${{ parameters.codeCoverage }}, True))
- task: PublishTestResults@2

@eerhardt eerhardt Dec 8, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want this? I don't see the Test tab on the CI build in this PR:

image

Publishing the test results allows Azure DevOps to easily show test failures:

image
#Resolved

@frank-dong-ms-zz frank-dong-ms-zz Dec 8, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After migrate to arcade we are not generating any trx test results so this step is not necessary any more. we have a stage (the next next one) that upload test results (html format) if test fails.
I checked other builds from master there is also no Test tab on the build definition. Is html test result not work with build pipeline(showing test pages)? If so can we chagne the test output to trx?


In reply to: 538723243 [](ancestors = 538723243)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Eric's point maybe that Azure has the capability to show test failures right away without having to scan through the build logs. We aren't generating trx test results, but maybe Arcade has a different mechanism to enable this. Can you please look into it?


In reply to: 538732212 [](ancestors = 538732212,538723243)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will take a look, that can be done in separate PR.


In reply to: 538734618 [](ancestors = 538734618,538732212,538723243)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.


In reply to: 538752000 [](ancestors = 538752000,538734618,538732212,538723243)

displayName: Publish Test Results
condition: succeededOrFailed()
inputs:
testRunner: 'vSTest'
searchFolder: '$(System.DefaultWorkingDirectory)/artifacts/TestResults'
testResultsFiles: '**/*.trx'
testRunTitle: Machinelearning_Tests_${{ parameters.name }}_$(_configuration)_$(Build.BuildNumber)
configuration: $(_configuration)
mergeTestResults: true
- task: CopyFiles@2
displayName: Stage build logs
condition: not(succeeded())
Expand Down
14 changes: 7 additions & 7 deletions build/vsts-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,10 @@ phases:
steps:
- script: ./restore.sh
displayName: restore all projects
- script: ./build.sh -configuration $(BuildConfig) /p:SkipRIDAgnosticAssets=true -projects $(Build.SourcesDirectory)/src/Redist/Microsoft.ML.DnnImageFeaturizer.ModelRedist/Microsoft.ML.DnnImageFeaturizer.ModelRedist.proj
- script: ./build.sh -configuration $(BuildConfig) /p:CopyPackageAssets=true /p:SkipRIDAgnosticAssets=true -projects $(Build.SourcesDirectory)/src/Redist/Microsoft.ML.DnnImageFeaturizer.ModelRedist/Microsoft.ML.DnnImageFeaturizer.ModelRedist.proj
displayName: build redist
# Only build native assets to avoid conflicts.
- script: ./build.sh -configuration $(BuildConfig) -projects $(Build.SourcesDirectory)/src/Native/Native.proj /p:TargetArchitecture=x64
- script: ./build.sh -configuration $(BuildConfig) -projects $(Build.SourcesDirectory)/src/Native/Native.proj /p:TargetArchitecture=x64 /p:CopyPackageAssets=true
displayName: Build

- task: PublishBuildArtifacts@1
Expand Down Expand Up @@ -60,10 +60,10 @@ phases:
displayName: Install build dependencies
- script: ./restore.sh
displayName: restore all projects
- script: ./build.sh -configuration $(BuildConfig) /p:SkipRIDAgnosticAssets=true -projects $(Build.SourcesDirectory)/src/Redist/Microsoft.ML.DnnImageFeaturizer.ModelRedist/Microsoft.ML.DnnImageFeaturizer.ModelRedist.proj
- script: ./build.sh -configuration $(BuildConfig) /p:CopyPackageAssets=true /p:SkipRIDAgnosticAssets=true -projects $(Build.SourcesDirectory)/src/Redist/Microsoft.ML.DnnImageFeaturizer.ModelRedist/Microsoft.ML.DnnImageFeaturizer.ModelRedist.proj
displayName: build redist
# Only build native assets to avoid conflicts.
- script: ./build.sh -projects $(Build.SourcesDirectory)/src/Native/Native.proj -configuration $(BuildConfig) /p:TargetArchitecture=x64
- script: ./build.sh -projects $(Build.SourcesDirectory)/src/Native/Native.proj -configuration $(BuildConfig) /p:TargetArchitecture=x64 /p:CopyPackageAssets=true
displayName: Build

- task: PublishBuildArtifacts@1
Expand Down Expand Up @@ -104,10 +104,10 @@ phases:

- script: ./restore.cmd
displayName: restore all projects
- script: ./build.cmd -configuration $(BuildConfig) /p:SkipRIDAgnosticAssets=true -projects $(Build.SourcesDirectory)/src/Redist/Microsoft.ML.DnnImageFeaturizer.ModelRedist/Microsoft.ML.DnnImageFeaturizer.ModelRedist.proj
- script: ./build.cmd -configuration $(BuildConfig) /p:CopyPackageAssets=true /p:SkipRIDAgnosticAssets=true -projects $(Build.SourcesDirectory)/src/Redist/Microsoft.ML.DnnImageFeaturizer.ModelRedist/Microsoft.ML.DnnImageFeaturizer.ModelRedist.proj
displayName: build redist
# Only build native assets to avoid conflicts.
- script: ./build.cmd -projects $(Build.SourcesDirectory)/src/Native/Native.proj -configuration $(BuildConfig) /p:TargetArchitecture=x86
- script: ./build.cmd -projects $(Build.SourcesDirectory)/src/Native/Native.proj -configuration $(BuildConfig) /p:TargetArchitecture=x86 /p:CopyPackageAssets=true
displayName: Build

- script: ./sign.cmd -configuration $(BuildConfig) /p:TargetArchitecture=x86 /p:SignBinaries=true
Expand Down Expand Up @@ -154,7 +154,7 @@ phases:
condition: and(succeeded(), in(variables._SignType, 'real', 'test'))

# Build both native and managed assets.
- script: ./build.cmd -configuration $(BuildConfig) /p:TargetArchitecture=x64
- script: ./build.cmd -configuration $(BuildConfig) /p:TargetArchitecture=x64 /p:CopyPackageAssets=true
displayName: Build

- task: ComponentGovernanceComponentDetection@0
Expand Down
2 changes: 1 addition & 1 deletion src/Directory.Build.targets
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<Import Project="..\Directory.Build.targets" />

<Target Name="PreparePackageAssets"
<Target Name="PreparePackageAssets" Condition="'$(CopyPackageAssets)' == 'true'"
AfterTargets="Build">

<ItemGroup Condition="'$(IncludeInPackage)' != ''">
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.Extensions.ML/Microsoft.Extensions.ML.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.Extensions.ML</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this property be included in some top level Directory.Build.props?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is great idea, I think we can.


In reply to: 538041772 [](ancestors = 538041772)

<PackageDescription>An integration package for ML.NET models on scalable web apps and services.</PackageDescription>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.ML.AutoML/Microsoft.ML.AutoML.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.AutoML</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>ML.NET AutoML: Optimizes an ML pipeline for your dataset, by automatically locating the best feature engineering, model, and hyperparameters</PackageDescription>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.CodeGenerator</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>ML.NET Code Generator</PackageDescription>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.ML.CpuMath/Microsoft.ML.CpuMath.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFrameworks>netstandard2.0;netcoreapp3.1</TargetFrameworks>
<IncludeInPackage>Microsoft.ML.CpuMath</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>Microsoft.ML.CpuMath contains optimized math routines for ML.NET.</PackageDescription>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<DefineConstants>$(DefineConstants);CPUMATH_INFRASTRUCTURE</DefineConstants>
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.ML.DataView/Microsoft.ML.DataView.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.DataView</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>Contains the IDataView system which is a set of interfaces and components that provide efficient, compositional processing of schematized data for machine learning and advanced analytics applications.</PackageDescription>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.DnnImageFeaturizer.AlexNet</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>ML.NET component for pretrained AlexNet image featurization</PackageDescription>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.DnnImageFeaturizer.ResNet101</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>ML.NET component for pretrained ResNet101 image featurization</PackageDescription>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.DnnImageFeaturizer.ResNet18</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>ML.NET component for pretrained ResNet18 image featurization</PackageDescription>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.DnnImageFeaturizer.ResNet50</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>ML.NET component for pretrained ResNet50 image featurization</PackageDescription>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.ML.Ensemble/Microsoft.ML.Ensemble.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.Ensemble</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>ML.NET component for Ensembles</PackageDescription>
<DefineConstants>CORECLR</DefineConstants>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.EntryPoints</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>Microsoft.ML.EntryPoints contains the ML.NET entry point API catalog.</PackageDescription>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.Experimental</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>Microsoft.ML.Experimental contains experimental work such extension methods to access internal methods.</PackageDescription>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.ML.FastTree/Microsoft.ML.FastTree.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.FastTree</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>ML.NET component for FastTree</PackageDescription>
<DefineConstants>$(DefineConstants);USE_FASTTREENATIVE;NO_STORE;CORECLR</DefineConstants>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFrameworks>netstandard2.0;netcoreapp2.1</TargetFrameworks>
<IncludeInPackage>Microsoft.ML.Featurizers</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<PackageDescription>ML.NET featurizers with native code implementation</PackageDescription>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.ImageAnalytics</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>ML.NET component for Image support</PackageDescription>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.ML.LightGbm/Microsoft.ML.LightGbm.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.LightGbm</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<PackageDescription>ML.NET component for LightGBM</PackageDescription>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.Mkl.Components</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<PackageDescription>ML.NET additional learners making use of Intel Mkl.</PackageDescription>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.ML.Mkl.Redist/Microsoft.ML.Mkl.Redist.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<IncludeBuildOutput>false</IncludeBuildOutput>
<TargetFramework>netstandard2.0</TargetFramework>
<PackageLicenseFile>LICENSE.txt</PackageLicenseFile>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>$(MSBuildProjectName) contains the MKL library redistributed as a NuGet package.</PackageDescription>
<PackageTags>$(PackageTags) MLNET MKL</PackageTags>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.OnnxConverter</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<RootNamespace>Microsoft.ML.Model.Onnx</RootNamespace>
<PackageDescription>ML.NET component for exporting ONNX Models</PackageDescription>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.OnnxTransformer</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<PackageDescription>ML.NET component for Microsoft.ML.Scoring library</PackageDescription>
</PropertyGroup>
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.ML.Parquet/Microsoft.ML.Parquet.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.Parquet</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>ML.NET components for Apache Parquet support.</PackageDescription>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.Recommender</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<PackageDescription>LIBMF, the core computation library for matrix factorization in ML.NET</PackageDescription>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.SampleUtils</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>Sample utils for Microsoft.ML.Samples</PackageDescription>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.ML.TensorFlow/Microsoft.ML.TensorFlow.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.TensorFlow</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<DefineConstants>CORECLR</DefineConstants>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<PackageDescription>Microsoft.ML.TensorFlow contains ML.NET integration of TensorFlow.</PackageDescription>
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.ML.TimeSeries/Microsoft.ML.TimeSeries.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.TimeSeries</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<PackageDescription>Microsoft.ML.TimeSeries contains ML.NET Time Series prediction algorithms. Uses Intel Mkl.</PackageDescription>
</PropertyGroup>

Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.ML.Vision/Microsoft.ML.Vision.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeInPackage>Microsoft.ML.Vision</IncludeInPackage>
<NoWarn>$(NoWarn);NU5118</NoWarn>
<DefineConstants>CORECLR</DefineConstants>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<PackageDescription>Microsoft.ML.Vision contains high level APIs for vision tasks like image classification.</PackageDescription>
Expand Down
1 change: 1 addition & 0 deletions src/Microsoft.ML/Microsoft.ML.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IncludeBuildOutput>false</IncludeBuildOutput>
<NoWarn>$(NoWarn);NU5118;NU5127;NU5128</NoWarn>
<PackageDescription>ML.NET is a cross-platform open-source machine learning framework which makes machine learning accessible to .NET developers.</PackageDescription>
</PropertyGroup>

Expand Down