Skip to content

Improving error message #5444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harishsk merged 2 commits into from
Oct 27, 2020
Merged

Improving error message #5444

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1501580
better error fix
Oct 20, 2020
0180e08
revisions
Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.ML.Data/Transforms/ColumnConcatenatingEstimator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,8 @@ private SchemaShape.Column CheckInputsAndMakeColumn(
}
if (!col.ItemType.Equals(itemType))
{
throw _host.Except($"Column '{sources[i]}' has values of {col.ItemType}, " +
$"which is not the same as earlier observed type of {itemType}.");
throw _host.Except($"Concatenated columns should have the same type. Column '{sources[i]}' has values of {col.ItemType}, " +
$"but expected columns of type {itemType}.");

@frank-dong-ms-zz frank-dong-ms-zz Oct 20, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Column '{sources[i]}' has type of {col.ItemType}, " +
$"but expected column type is {itemType}.

Will that be more clear?

@kere-nel kere-nel Oct 20, 2020

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I can remove the first sentence, if we think the user will know concatenated columns must have the same type.

@antoniovs1029 antoniovs1029 Oct 20, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the first sentence is all right. But maybe use the wording Frank suggested for the second one?

@frank-dong-ms-zz frank-dong-ms-zz Oct 20, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, first sentence is good, I mean change the second sentence little bit.

In reply to: 508886394 [](ancestors = 508886394)

}
varVector |= col.Kind == SchemaShape.Column.VectorKind.VariableVector;
isNormalized &= col.IsNormalized();
Expand Down