Added IsotonicCalibrator ONNX Export Support#5298
Closed
mstfbl wants to merge 3 commits intodotnet:masterfrom
Closed
Added IsotonicCalibrator ONNX Export Support#5298mstfbl wants to merge 3 commits intodotnet:masterfrom
mstfbl wants to merge 3 commits intodotnet:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5298 +/- ##
===========================================
+ Coverage 73.68% 87.62% +13.94%
===========================================
Files 1022 243 -779
Lines 190366 44548 -145818
Branches 20474 1896 -18578
===========================================
- Hits 140265 39036 -101229
+ Misses 44568 5167 -39401
+ Partials 5533 345 -5188
|
Codecov Report
@@ Coverage Diff @@
## master #5298 +/- ##
==========================================
- Coverage 73.80% 73.64% -0.17%
==========================================
Files 1022 1022
Lines 190617 190466 -151
Branches 20488 20475 -13
==========================================
- Hits 140686 140264 -422
- Misses 44411 44670 +259
- Partials 5520 5532 +12
|
harishsk
reviewed
Jul 10, 2020
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP PR to add ONNX export support for the Isotonic Calibrator
Current work remaining is implementing if-then-else conditionals. Intermediate calculations and if-then-else inputs are already implemented.
I will add tests (first written in this commit) for validating IsotonicCalibrator with ONNX and merge with upstream once PR #5289 is merged.