[Issue4484] Support specifying command timeout while using the database loader#5288
Merged
wangyems merged 9 commits intodotnet:masterfrom Jul 8, 2020
wangyems:wangye/x
Merged
[Issue4484] Support specifying command timeout while using the database loader#5288wangyems merged 9 commits intodotnet:masterfrom wangyems:wangye/x
wangyems merged 9 commits intodotnet:masterfrom
wangyems:wangye/x
Conversation
src/Microsoft.ML.Data/DataLoadSave/Database/DatabaseLoaderCursor.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #5288 +/- ##
==========================================
- Coverage 73.68% 69.51% -4.17%
==========================================
Files 1022 779 -243
Lines 190320 145811 -44509
Branches 20470 18576 -1894
==========================================
- Hits 140232 101366 -38866
+ Misses 44557 39273 -5284
+ Partials 5531 5172 -359
|
Codecov Report
@@ Coverage Diff @@
## master #5288 +/- ##
==========================================
+ Coverage 73.68% 73.75% +0.07%
==========================================
Files 1022 1022
Lines 190320 190360 +40
Branches 20470 20472 +2
==========================================
+ Hits 140232 140404 +172
+ Misses 44557 44439 -118
+ Partials 5531 5517 -14
|
mstfbl
reviewed
Jul 7, 2020
Contributor
harishsk
reviewed
Jul 7, 2020
Contributor
Author
harishsk
reviewed
Jul 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix issue 4484
-add option to set db command timeout in db loader
-add corresponding test
this pr partially refers to a hanging PR.