Skip to content

Support onnx export with previous OpSet version#5176

Merged
wangyems merged 21 commits intodotnet:masterfrom
wangyems:wangye/oldopset2
Jun 3, 2020
Merged

Support onnx export with previous OpSet version#5176
wangyems merged 21 commits intodotnet:masterfrom
wangyems:wangye/oldopset2

Conversation

@wangyems
Copy link
Contributor

@wangyems wangyems commented May 29, 2020

For Feature request: #5171

Support exporting to onnx with a lower opset version
upgrade opset version from 11 to 12

@wangyems wangyems requested a review from a team as a code owner May 29, 2020 02:02
@wangyems wangyems marked this pull request as draft May 29, 2020 02:24
@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #5176 into master will decrease coverage by 0.00%.
The diff coverage is 74.35%.

@@            Coverage Diff             @@
##           master    #5176      +/-   ##
==========================================
- Coverage   73.32%   73.31%   -0.01%     
==========================================
  Files        1007     1007              
  Lines      187911   188075     +164     
  Branches    20241    20244       +3     
==========================================
+ Hits       137790   137895     +105     
- Misses      44595    44657      +62     
+ Partials     5526     5523       -3     
Flag Coverage Δ
#Debug 73.31% <74.35%> (-0.01%) ⬇️
#production 69.08% <98.24%> (+<0.01%) ⬆️
#test 87.40% <51.66%> (-0.05%) ⬇️
Impacted Files Coverage Δ
src/Microsoft.ML.Data/Model/Onnx/OnnxContext.cs 100.00% <ø> (ø)
test/Microsoft.ML.Tests/OnnxConversionTest.cs 96.81% <51.66%> (-2.16%) ⬇️
src/Microsoft.ML.OnnxConverter/OnnxContextImpl.cs 72.91% <88.88%> (+0.38%) ⬆️
src/Microsoft.ML.Data/Prediction/Calibrator.cs 80.28% <100.00%> (+0.01%) ⬆️
....Data/Transforms/ColumnConcatenatingTransformer.cs 84.64% <100.00%> (+0.02%) ⬆️
src/Microsoft.ML.Data/Transforms/ColumnCopying.cs 97.19% <100.00%> (+0.02%) ⬆️
...rc/Microsoft.ML.Data/Transforms/ColumnSelecting.cs 96.29% <100.00%> (+0.01%) ⬆️
src/Microsoft.ML.Data/Transforms/Hashing.cs 81.41% <100.00%> (+0.01%) ⬆️
src/Microsoft.ML.Data/Transforms/KeyToValue.cs 71.57% <100.00%> (+0.07%) ⬆️
src/Microsoft.ML.Data/Transforms/KeyToVector.cs 83.67% <100.00%> (+0.03%) ⬆️
... and 57 more

@wangyems wangyems marked this pull request as ready for review May 29, 2020 19:31
@wangyems wangyems marked this pull request as draft May 30, 2020 00:21
@wangyems wangyems marked this pull request as ready for review May 30, 2020 00:28
@wangyems wangyems requested a review from harishsk May 30, 2020 00:30
@wangyems wangyems marked this pull request as ready for review June 1, 2020 23:14
@wangyems wangyems marked this pull request as draft June 2, 2020 18:16
@wangyems wangyems marked this pull request as ready for review June 2, 2020 19:39
Copy link
Contributor

@harishsk harishsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wangyems wangyems merged commit d1bf425 into dotnet:master Jun 3, 2020
@wangyems wangyems deleted the wangye/oldopset2 branch June 9, 2020 20:18
@ghost ghost locked as resolved and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments