Skip to content

Auto.ML: Fix issue when parsing float string fails on pl-PL culture set using Regression Experiment #5163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antoniovs1029 merged 14 commits into from
Oct 30, 2020
Merged

Auto.ML: Fix issue when parsing float string fails on pl-PL culture set using Regression Experiment #5163

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e9baae9
Fix issue when parsing float string fails on pl-PL culture set
ptelman May 25, 2020
e58dd15
Added InvariantCulture float parsing as per CodeReview request
ptelman May 26, 2020
a956afb
Update src/Microsoft.ML.AutoML/Sweepers/SweeperProbabilityUtils.cs
ptelman Oct 28, 2020
3724f55
Update Parameters.cs
ptelman Oct 28, 2020
fb9b984
Merge remote-tracking branch 'upstream/master' into ptelman-master
antoniovs1029 Oct 28, 2020
32f931e
Added PL test
antoniovs1029 Oct 28, 2020
ff65570
Added multiple cultures
antoniovs1029 Oct 29, 2020
4f6b119
debugging CI failure
antoniovs1029 Oct 29, 2020
95b7280
Debug runSpecific
antoniovs1029 Oct 29, 2020
c8eb41d
Revert "Debug runSpecific"
antoniovs1029 Oct 29, 2020
3f42e07
Removed LightGBM and addressed comments
antoniovs1029 Oct 29, 2020
d41623a
Increased time
antoniovs1029 Oct 29, 2020
645f590
Increase time
antoniovs1029 Oct 29, 2020
e372664
Increased time
antoniovs1029 Oct 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Microsoft.ML.AutoML/Sweepers/SweeperProbabilityUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,15 @@ public static float[] ParameterSetAsFloatArray(IValueGenerator[] sweepParams, Pa
}
else if (sweepParam is LongValueGenerator lvg)
{
var longValue = GetIfIParameterValueOfT<long>(pset) ?? long.Parse(pset.ValueText);
Comment thread
ptelman marked this conversation as resolved.
Outdated
// Normalizing all numeric parameters to [0,1] range.
result.Add(lvg.NormalizeValue(new LongParameterValue(pset.Name, long.Parse(pset.ValueText))));
result.Add(lvg.NormalizeValue(new LongParameterValue(pset.Name, longValue)));
}
else if (sweepParam is FloatValueGenerator fvg)
{
var floatValue = GetIfIParameterValueOfT<float>(pset) ?? float.Parse(pset.ValueText);
// Normalizing all numeric parameters to [0,1] range.
result.Add(fvg.NormalizeValue(new FloatParameterValue(pset.Name, float.Parse(pset.ValueText))));
Comment thread
antoniovs1029 marked this conversation as resolved.
result.Add(fvg.NormalizeValue(new FloatParameterValue(pset.Name, floatValue)));
}
else
{
Expand All @@ -115,6 +117,10 @@ public static float[] ParameterSetAsFloatArray(IValueGenerator[] sweepParams, Pa
return result.ToArray();
}

private static T? GetIfIParameterValueOfT<T>(IParameterValue parameterValue)
where T : struct =>
parameterValue is IParameterValue<T> pvt ? pvt.Value : default(T?);
Comment thread
antoniovs1029 marked this conversation as resolved.

public static ParameterSet FloatArrayAsParameterSet(IValueGenerator[] sweepParams, float[] array, bool expandedCategoricals = true)
{
Runtime.Contracts.Assert(array.Length == sweepParams.Length);
Comment thread
antoniovs1029 marked this conversation as resolved.
Expand Down